From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: "Eric S. Raymond" <esr@thyrsus.com>,
emacs-pretest-bug@gnu.org,
Chris Moore <christopher.ian.moore@gmail.com>
Subject: Re: log-view.el calls non-existent function vc-version-diff
Date: Sat, 13 Oct 2007 22:07:58 -0400 [thread overview]
Message-ID: <jwvprzi30vm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <200710131744.l9DHiL4Z023009@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Sat\, 13 Oct 2007 10\:44\:21 -0700")
>> The only 2 references to vc-version-diff in the whole lisp/ tree are:
>>
>> ./log-view.el:(autoload 'vc-version-diff "vc")
>> ./log-view.el: (vc-version-diff (log-view-current-file) to fr)))
> It seems that it should be changed to call vc-history-diff.
> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...
> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?
In any case, vc.el should provide a backward compatibility definition of
vc-version-diff (and mark it obsolete).
Stefan
prev parent reply other threads:[~2007-10-14 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 13:21 log-view.el calls non-existent function vc-version-diff Chris Moore
2007-10-13 17:44 ` Dan Nicolaescu
2007-10-14 2:07 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvprzi30vm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=christopher.ian.moore@gmail.com \
--cc=dann@ics.uci.edu \
--cc=emacs-pretest-bug@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).