unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: ChangeLog removal
Date: Thu, 01 May 2008 11:19:12 -0400	[thread overview]
Message-ID: <jwvprs65a6y.fsf-monnier+emacs@gnu.org> (raw)

When undoing someone's commit, never remove the changelog entry.
Instead, add another entry saying that you reverted a change.
This is in reference to the attached patch.


        Stefan


revision 1.13572
date: 2008-04-27 05:46:57 -0400;  author: schwab;  state: Exp;  lines: +0 -2;  commitid: J0UjWj30wxmGmJ0t;
Unbreak bootstrap.
----------------------------

Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.13571
retrieving revision 1.13572
diff -u -r1.13571 -r1.13572
--- lisp/ChangeLog	27 Apr 2008 09:30:36 -0000	1.13571
+++ lisp/ChangeLog	27 Apr 2008 09:46:57 -0000	1.13572
@@ -280,8 +280,6 @@
 	* cus-start.el: Remove insert-default-directory and
 	read-file-name-completion-ignore-case.
 
-	* Makefile.in (emacs-deps): Leave it empty.
-
 2008-04-23  Magnus Henoch  <mange@freemail.hu>
 
 	* tar-mode.el (tar-untar-buffer): If the entry has directory




             reply	other threads:[~2008-05-01 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 15:19 Stefan Monnier [this message]
2008-05-01 17:46 ` ChangeLog removal Glenn Morris
2008-05-01 19:42   ` Jason Rumney
2008-05-02 14:43     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvprs65a6y.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).