From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: nobu@ruby-lang.org, Leo <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: ruby-mode : ruby-mode-set-encoding
Date: Tue, 03 Mar 2009 11:30:51 -0500 [thread overview]
Message-ID: <jwvprgya7ve.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <xbaifxhupv6e.fsf@cam.ac.uk> (Leo's message of "Tue, 03 Mar 2009 13:55:53 +0000")
>> (defun ruby-mode-set-encoding ()
>> "Insert a magic comment header with the proper encoding if necessary."
>> ...
>>
>> and AFAIK only ruby mode use this type of thing. It is added to saving
>> functions hooks :
>>
>> (add-hook
>> (cond ((boundp 'before-save-hook)
>> (make-local-variable 'before-save-hook)
>> 'before-save-hook)
>> ((boundp 'write-contents-functions) 'write-contents-functions)
>> ((boundp 'write-contents-hooks) 'write-contents-hooks))
>> 'ruby-mode-set-encoding)
> I agree. I think this is just too intrusive. Fortunately, I don't use ruby.
I don't know if it's too intrusive, but it seems unrelated to Ruby.
Nobuyoshi Nakada, looking at the history of ruby-mode.el at
http://svn.ruby-lang.org/repos/ruby/trunk/misc, it appears the change is
due to you, could you explain what this is intended to do?
If it's not specific to Ruby, then maybe it should be moved elsewhere.
Stefan
next prev parent reply other threads:[~2009-03-03 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 13:46 ruby-mode : ruby-mode-set-encoding Paul R
2009-03-03 13:55 ` Leo
2009-03-03 16:30 ` Stefan Monnier [this message]
2009-03-04 0:23 ` Nobuyoshi Nakada
2009-03-04 1:14 ` Stefan Monnier
2009-03-04 2:05 ` Stephen J. Turnbull
2009-03-04 4:07 ` Stefan Monnier
2009-03-04 6:10 ` Stephen J. Turnbull
2009-03-04 14:10 ` Stefan Monnier
2009-03-04 15:07 ` Stephen J. Turnbull
2009-03-04 16:40 ` Stefan Monnier
2009-03-04 8:25 ` Paul R
2009-03-04 14:13 ` Stefan Monnier
2009-03-04 14:56 ` Nobuyoshi Nakada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvprgya7ve.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=nobu@ruby-lang.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).