Build failure in current git checkout

Build failure in current git checkout

[Manoj Srivastava]

Hi,

        I am getting a build failure for the master branch from the git
 repository, summarized below (I can provide more details if needed)

        manoj

test ! -e Makefile || make maintainer-clean
./configure --with-x-toolkit=gtk --with-dbus --with-gpm --with-pop=yes \
     --with-xpm --with-jpeg --with-tiff --with-gif --with-png --with-x \
                    --with-xft --with-freetype --with-rsvg --with-libotf

  ...

Configured for `x86_64-unknown-linux-gnu'.

  Where should the build process find the source code?    /usr/local/src/emacs
  What operating system and machine description files should Emacs use?
        `s/gnu-linux.h' and `m/amdx86-64.h'
  What compiler should emacs be built with?               gcc -g -O2 -Wno-pointer-sign  
  Should Emacs use the GNU version of malloc?             yes
      (Using Doug Lea's new malloc from the GNU C Library.)
  Should Emacs use a relocating allocator for buffers?    yes
  Should Emacs use mmap(2) for buffer allocation?         no
  What window system should Emacs use?                    x11
  What toolkit should Emacs use?                          GTK
  Where do we find X Windows header files?                Standard dirs
  Where do we find X Windows libraries?                   Standard dirs
  Does Emacs use -lXaw3d?                                 no
  Does Emacs use -lXpm?                                   yes
  Does Emacs use -ljpeg?                                  yes
  Does Emacs use -ltiff?                                  yes
  Does Emacs use a gif library?                           yes -lgif
  Does Emacs use -lpng?                                   yes
  Does Emacs use -lrsvg-2?                                yes
  Does Emacs use -lgpm?                                   yes
  Does Emacs use -ldbus?                                  yes
  Does Emacs use -lfreetype?                              yes
  Does Emacs use -lm17n-flt?                              yes
  Does Emacs use -lotf?                                   yes
  Does Emacs use -lxft?                                   yes
  Does Emacs use toolkit scroll bars?                     yes


 ...

cd ../lisp; make -w update-subdirs
make[3]: Entering directory `/usr/local/src/emacs/lisp'
wd=/usr/local/src/emacs/lisp; subdirs=`(cd $wd; find . -type d -print)`; for file in $subdirs; do case $file in */Old | */RCS | */CVS | */CVS/* | */.* | */.*/* | */=* ) ;; *) wins="$wins $wd/$file" ;; esac; done; \
        for file in $wins; do \
           /usr/local/src/emacs/lisp/../update-subdirs $file; \
        done;
make[3]: Leaving directory `/usr/local/src/emacs/lisp'
`/bin/pwd`/temacs --batch --load loadup bootstrap
make[2]: *** [bootstrap-emacs] Segmentation fault
make[2]: Leaving directory `/usr/local/src/emacs/src'
make[1]: *** [src] Error 2
make[1]: Leaving directory `/usr/local/src/emacs'
make: *** [bootstrap] Error 2

-- 
diplomacy, n: Lying in state.
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

Re: Build failure in current git checkout

[Daniel Clemente]

> `/bin/pwd`/temacs --batch --load loadup bootstrap
> make[2]: *** [bootstrap-emacs] Segmentation fault
> make[2]: Leaving directory `/usr/local/src/emacs/src'
> make[1]: *** [src] Error 2
> make[1]: Leaving directory `/usr/local/src/emacs'
> make: *** [bootstrap] Error 2

  This is definitely the same as I experienced: Building Emacs overflowed pure space.
  I have documented it here: http://www.emacswiki.org/emacs/EmacsMemoryDebugging#toc9

-- Daniel

Re: Build failure in current git checkout

[Teemu Likonen]

On 2009-08-05 23:43 (-0500), Manoj Srivastava wrote:

>         I am getting a build failure for the master branch from the git
>  repository, summarized below (I can provide more details if needed)

> `/bin/pwd`/temacs --batch --load loadup bootstrap
> make[2]: *** [bootstrap-emacs] Segmentation fault
> make[2]: Leaving directory `/usr/local/src/emacs/src'
> make[1]: *** [src] Error 2
> make[1]: Leaving directory `/usr/local/src/emacs'
> make: *** [bootstrap] Error 2

I git-bisected it to this commit:


commit 3cd069ec588527f4baac7a71d93ccc080668eebf
Author: Teodor Zlatanov <tzz@lifelogs.com>
Date:   Wed Aug 5 09:19:21 2009 +0000

    * lread.c (read1, syms_of_lread): Read hashtables back from the
    readable format.
    
    * print.c (print_preprocess, print_object): Print hashtables fully
    and readably.
    (syms_of_print): Provide 'hashtable-print-readable.

hashtable-print-readable provide point (was: Build failure in current git checkout)

[Ted Zlatanov]

On Wed, 05 Aug 2009 23:43:23 -0500 Manoj Srivastava <srivasta@ieee.org> wrote: 

MS>         I am getting a build failure for the master branch from the git
MS>  repository, summarized below (I can provide more details if needed)

On Thu, 06 Aug 2009 13:39:37 +0300 Teemu Likonen <tlikonen@iki.fi> wrote: 

TL> I git-bisected it to this commit:

TL> commit 3cd069ec588527f4baac7a71d93ccc080668eebf
TL> Author: Teodor Zlatanov <tzz@lifelogs.com>
TL> Date:   Wed Aug 5 09:19:21 2009 +0000

TL>     * lread.c (read1, syms_of_lread): Read hashtables back from the
TL>     readable format.
    
TL>     * print.c (print_preprocess, print_object): Print hashtables fully
TL>     and readably.
TL>     (syms_of_print): Provide 'hashtable-print-readable.

On Thu, 6 Aug 2009 03:13:55 -0700 (PDT) Dan Nicolaescu <dann@ics.uci.edu> wrote: 

DN> This patch breaks the build, temacs crashes on startup.

DN> You cannot call Fprovide in print.c, it's initialized later than that.

When I tested I didn't do a full build.  I'll gladly move the call

  Fprovide (intern ("hashtable-print-readable"), Qnil);
  
to wherever it belongs, but I don't see `provide' called in any other .c
files except for xfns.c (X functions), dbusbins.c, process.c, and
terminal.c.  I don't think this `provide' call belongs in any of them.
I guess process.c is the closest one, but I'd rather not pollute it with
unrelated code.

I can put the `provide' call in the lisp/ tree but again, I don't know
where it should go there.

Ted

Re: hashtable-print-readable provide point (was: Build failure in current git checkout)

[Andreas Schwab]

Ted Zlatanov <tzz@lifelogs.com> writes:

> I can put the `provide' call in the lisp/ tree but again, I don't know
> where it should go there.

I think subr.el would be a good place.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: hashtable-print-readable provide point

[Ted Zlatanov]

On Thu, 06 Aug 2009 14:56:36 +0200 Andreas Schwab <schwab@linux-m68k.org> wrote: 

AS> Ted Zlatanov <tzz@lifelogs.com> writes:
>> I can put the `provide' call in the lisp/ tree but again, I don't know
>> where it should go there.

AS> I think subr.el would be a good place.

I don't have a way to commit until tomorrow.  If someone with write
access (Stefan?  Chong?  Andreas?) could please make and test that
change, plus the NEWS change I suggested yesterday, and write back, I
would appreciate it.

Thanks
Ted

Re: hashtable-print-readable provide point

[Stefan Monnier]

>> I can put the `provide' call in the lisp/ tree but again, I don't know
>> where it should go there.

> I think subr.el would be a good place.

In that case, since it's not next to the relevant code, it should
probably be written defensively as

  (when (hash-table-p (read-from-string (prin1-to-string (make-hash-table))))
    (provide 'hashtable-print-readable))


-- Stefan

Re: hashtable-print-readable provide point

[Chong Yidong]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>   (when (hash-table-p (read-from-string (prin1-to-string (make-hash-table))))
>     (provide 'hashtable-print-readable))

The test doesn't seem to work.  Is the code implemented correctly?

Re: hashtable-print-readable provide point

[Stefan Monnier]

>> (when (hash-table-p (read-from-string (prin1-to-string (make-hash-table))))
>>   (provide 'hashtable-print-readable))
> The test doesn't seem to work.  Is the code implemented correctly?

This is email-code, of course: guaranteed 100% untested.


        Stefan

Re: hashtable-print-readable provide point

[Ted Zlatanov]

On Sat, 08 Aug 2009 15:55:26 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>>> (when (hash-table-p (read-from-string (prin1-to-string (make-hash-table))))
>>> (provide 'hashtable-print-readable))
>> The test doesn't seem to work.  Is the code implemented correctly?

SM> This is email-code, of course: guaranteed 100% untested.

Sorry I didn't respond sooner: read-from-string returns a cons cell, so
(car ...) needs to be called.  subr.el already has the right invocation
in the provide.

On Thu, 06 Aug 2009 18:58:13 +0200 Florian Beck <abstraktion@t-online.de> wrote: 

FB> Ted Zlatanov <tzz@lifelogs.com> writes:

>> I've committed the patch with the usual ChangeLog information.

FB> I was in eager anticipation for this patch, but I can't get it to work
FB> with strings as keys:

FB> (let ((hashtable (make-hash-table :test 'equal)))
FB>   (puthash "key" "value" hashtable)
FB>   (gethash "key" (car (read-from-string (prin1-to-string hashtable)))))

FB>   => nil

Printing screwed up strings on both keys and their associated values.  I
installed a fix; the relevant piece was

	  for (i = 0; i < size; i++)
	    if (!NILP (HASH_HASH (h, i)))
	      {
		if (i) PRINTCHAR (' ');
		print_object (HASH_KEY (h, i), printcharfun, 0);
		PRINTCHAR (' ');
		print_object (HASH_VALUE (h, i), printcharfun, 0);
	      }

I should have had the escape flag (third argument) as 1 in order to
escape things correctly.  I tested it and it works for me.  Can you try?

Ted