From: Stefan Monnier <monnier@iro.umontreal.ca>
To: rms@gnu.org
Cc: dann@ics.uci.edu, emacs-devel@gnu.org, miles@gnu.org
Subject: Re: turning on minor modes from hooks
Date: Tue, 01 Sep 2009 19:23:56 -0400 [thread overview]
Message-ID: <jwvpraa1ccj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1Miam7-0006fZ-3T@fencepost.gnu.org> (Richard Stallman's message of "Tue, 01 Sep 2009 17:20:23 -0400")
> One design that occurs to me is (foo-mode) turns it on, (foo-mode t)
> turns it on, (foo-mode nil) turns it off, and the way you toggle is
> (foo-mode (not foo-mode)).
(foo-mode 'toggle) toggles it.
I'm not necessarily opposed to (foo-mode (not foo-mode)) but it can't be
used in the interactive spec, because we want the command-history to say
"toogle" rather than "turn on" or "turn off", in case the user wants to
repeat it.
> Another is (foo-mode) toggles,
That's what we have and it sucks, because it means that
(add-hook 'bar-hook foo-mode)
doesn't do what the user usually intends to do. Same thing with
-*- mode: foo -*-. That's why (foo-mode) needs to unconditionally turn
the mode on.
> The current convention for interactive calls seems clear and natural
> so I think it should be preserved, whatever we do with calls from Lisp.
Agreed.
Stefan
next prev parent reply other threads:[~2009-09-01 23:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 21:25 turning on minor modes from hooks Dan Nicolaescu
2009-08-29 23:18 ` Miles Bader
2009-08-30 0:14 ` Drew Adams
2009-08-30 2:11 ` Miles Bader
2009-08-30 3:01 ` Drew Adams
2009-08-30 3:58 ` Miles Bader
2009-08-30 3:59 ` Stefan Monnier
2009-08-30 4:00 ` Miles Bader
2009-08-31 3:33 ` Richard Stallman
2009-08-31 14:36 ` Stefan Monnier
2009-08-31 22:15 ` Miles Bader
2009-08-31 23:32 ` Stefan Monnier
2009-09-01 0:17 ` Miles Bader
2009-09-01 12:16 ` Richard Stallman
2009-09-01 16:19 ` Stefan Monnier
2009-09-01 21:20 ` Richard Stallman
2009-09-01 23:23 ` Stefan Monnier [this message]
2009-09-03 13:47 ` Richard Stallman
2009-09-04 21:23 ` Geoff Gole
2009-08-31 15:30 ` Daniel Colascione
2009-08-31 18:54 ` Tassilo Horn
2009-09-01 12:16 ` Richard Stallman
2009-08-31 23:43 ` Stefan Monnier
2009-09-01 2:07 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpraa1ccj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).