unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Deniz Dogan <deniz@dogan.se>
Cc: Juanma Barranquero <lekktu@gmail.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r104642: * src/process.c (Fset_process_buffer): Clarify return value in docstring.
Date: Tue, 21 Jun 2011 21:59:49 -0400	[thread overview]
Message-ID: <jwvpqm6eig9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4E00FC51.7050005@dogan.se> (Deniz Dogan's message of "Tue, 21 Jun 2011 22:17:21 +0200")

> I'm just wondering: can I rely on `set-process-buffer' always returning the
> buffer from now on or is it prone to change given the fact that it is
> "accidental"?

Now that you documented it, you can probably rely on it.
But if I undocument it before the release, then there's a risk it
might change.  If I were you I'd use

(defun dirc-setup-server-buffer (process)
  "Set up the server buffer for PROCESS."
  (let ((buffer (pop-to-buffer-same-window
                  (dirc-make-process-buffer-name process))))
    (set-process-buffer process buffer)))
    (with-current-buffer buffer
      (set (make-local-variable 'dirc-buffer-type) 'server)
      (set (make-local-variable 'dirc-process process)))))

which I find more readable and where you don't need to worry about it.


        Stefan



  reply	other threads:[~2011-06-22  1:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1QYeLs-00050O-9O@colonialone.fsf.org>
2011-06-20 14:26 ` [Emacs-diffs] /srv/bzr/emacs/trunk r104642: * src/process.c (Fset_process_buffer): Clarify return value in docstring Stefan Monnier
2011-06-20 16:16   ` Juanma Barranquero
2011-06-20 17:53     ` Stefan Monnier
2011-06-20 19:53       ` Juanma Barranquero
2011-06-21 14:13         ` Stefan Monnier
2011-06-21 14:30           ` Juanma Barranquero
2011-06-21 16:33             ` Stefan Monnier
2011-06-21 16:39               ` Juanma Barranquero
2011-06-21 20:17               ` Deniz Dogan
2011-06-22  1:59                 ` Stefan Monnier [this message]
2011-06-21  4:10       ` Stephen J. Turnbull
2011-06-21 16:00   ` Deniz Dogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpqm6eig9.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=deniz@dogan.se \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).