From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: file-subdir-of-p should also apply to files
Date: Sat, 31 Mar 2012 11:09:11 -0400 [thread overview]
Message-ID: <jwvpqbs6ccf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k421qnfw.fsf@gmail.com> (Thierry Volpiatto's message of "Sat, 31 Mar 2012 08:44:35 +0200")
>> Rather than (file-subdir-of-p DIR1 DIR2) we should have
>> (file-within-p FILE DIR).
> Why and where?
Why not?
> It is not a problem to copy a single file of TREE to a subdirectory of
> TREE, but it is a problem to copy TREE to one of its subdirectories,
> isn't it?
We're not talking about copying but about file-subdir-of-p.
The copy operation only uses file-subdir-of-p with a first argument
which is a directory, but that doesn't mean we shouldn't also handle
the case where the first argument is a file (which occurs in some
places which currently use string-prefix-p).
Stefan
next prev parent reply other threads:[~2012-03-31 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 20:54 file-subdir-of-p should also apply to files Stefan Monnier
2012-03-31 6:44 ` Thierry Volpiatto
2012-03-31 15:09 ` Stefan Monnier [this message]
2012-03-31 15:28 ` Deniz Dogan
2012-04-01 2:46 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpqbs6ccf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).