unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [RFC] Omit all GCPRO stuff if GC_MAKE_GCPROS_NOOPS
Date: Tue, 17 Jul 2012 03:20:47 -0400	[thread overview]
Message-ID: <jwvpq7uamj4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5002FF32.2090308@yandex.ru> (Dmitry Antipov's message of "Sun, 15 Jul 2012 21:34:42 +0400")

> This patch moves all GCPRO stuff out of compilation if GC_MARK_STACK
> == GC_MAKE_GCPROS_NOOPS.

I don't think it's terribly important to do that.
Unused variables are largely harmless.  Getting rid of unused structure
fields is OK, so feel free to commit this part of the patch.

I'm not completely averse to replacing those "struct gcpro gcpro1,
gcpro2, ..." with some kind of macro (tho I'd make it take an argument,
much like EXFUN), but then I'd like to find some way to make them expand
to something more empty than "*__dummy ATTRIBUTE_UNUSED = &__dummy".
This said, I don't like the suggestion to include the semi-colon in the
DEFGCPRO macros, so I'm not sure how else to do it, without bumping into
the "declarations after statements".


        Stefan



      parent reply	other threads:[~2012-07-17  7:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-15 17:34 [RFC] Omit all GCPRO stuff if GC_MAKE_GCPROS_NOOPS Dmitry Antipov
2012-07-16  6:41 ` Paul Eggert
2012-07-16 12:42   ` Michael Welsh Duggan
2012-07-16 13:39     ` Jan Djärv
2012-07-16 14:14     ` Paul Eggert
2012-07-17  7:20 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpq7uamj4.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).