From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113896: Declare external variables. Date: Thu, 15 Aug 2013 16:25:54 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376598375 8999 80.91.229.3 (15 Aug 2013 20:26:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Aug 2013 20:26:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 15 22:26:17 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VA47Z-00056d-S7 for ged-emacs-devel@m.gmane.org; Thu, 15 Aug 2013 22:26:13 +0200 Original-Received: from localhost ([::1]:55275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VA47Z-00075E-EU for ged-emacs-devel@m.gmane.org; Thu, 15 Aug 2013 16:26:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VA47O-000753-T9 for emacs-devel@gnu.org; Thu, 15 Aug 2013 16:26:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VA47G-0004zM-Hb for emacs-devel@gnu.org; Thu, 15 Aug 2013 16:26:02 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VA47G-0004zH-El for emacs-devel@gnu.org; Thu, 15 Aug 2013 16:25:54 -0400 Original-Received: from [98.143.210.201] (port=50663 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1VA47F-0001z6-ND; Thu, 15 Aug 2013 16:25:53 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B2A53660F8; Thu, 15 Aug 2013 16:25:54 -0400 (EDT) In-Reply-To: (Michael Albinus's message of "Thu, 15 Aug 2013 17:02:23 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162787 Archived-At: > +(eval-when-compile > + (defvar directory-sep-char) > + (defvar dired-move-to-filename-regexp)) You don't want to "eval" those defvars, since evaluating such a defvar is mostly a no-op. So don't put them inside eval-when-compile. Stefan