From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114239: * vc/vc-svn.el (vc-svn-retrieve-tag): Mark unused argument. Date: Thu, 12 Sep 2013 08:26:14 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378988800 6421 80.91.229.3 (12 Sep 2013 12:26:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Sep 2013 12:26:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 12 14:26:42 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VK5yq-0004zb-8h for ged-emacs-devel@m.gmane.org; Thu, 12 Sep 2013 14:26:40 +0200 Original-Received: from localhost ([::1]:41670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK5yp-0002FU-Ro for ged-emacs-devel@m.gmane.org; Thu, 12 Sep 2013 08:26:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK5yg-00027L-4y for emacs-devel@gnu.org; Thu, 12 Sep 2013 08:26:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK5yY-0002XZ-SK for emacs-devel@gnu.org; Thu, 12 Sep 2013 08:26:30 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:37183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK5yR-0002Us-3t; Thu, 12 Sep 2013 08:26:15 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r8CCQE7k008444; Thu, 12 Sep 2013 08:26:14 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 2327AB40D3; Thu, 12 Sep 2013 08:26:14 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Thu, 12 Sep 2013 06:55:28 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4698=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4698> : inlines <82> : streams <1036091> : uri <1534655> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163311 Archived-At: > -(defun vc-svn-retrieve-tag (dir name update) > +(defun vc-svn-retrieve-tag (dir name _update) > "Retrieve a tag at and below DIR. > NAME is the name of the tag; if it is empty, do a `svn update'. > If UPDATE is non-nil, then update (resynch) any affected buffers. I'm not sure this is a good idea. Is there a good reason why `update' is ignored? If not, then the fact that `update' is ignored is a bug, and we shouldn't silence it. Stefan