From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r114239: * vc/vc-svn.el (vc-svn-retrieve-tag): Mark unused argument.
Date: Thu, 12 Sep 2013 08:26:14 -0400 [thread overview]
Message-ID: <jwvppse1b2q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1VK0oK-00066t-Hr@vcs.savannah.gnu.org> (Glenn Morris's message of "Thu, 12 Sep 2013 06:55:28 +0000")
> -(defun vc-svn-retrieve-tag (dir name update)
> +(defun vc-svn-retrieve-tag (dir name _update)
> "Retrieve a tag at and below DIR.
> NAME is the name of the tag; if it is empty, do a `svn update'.
> If UPDATE is non-nil, then update (resynch) any affected buffers.
I'm not sure this is a good idea. Is there a good reason why `update'
is ignored? If not, then the fact that `update' is ignored is a bug,
and we shouldn't silence it.
Stefan
next parent reply other threads:[~2013-09-12 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VK0oK-00066t-Hr@vcs.savannah.gnu.org>
2013-09-12 12:26 ` Stefan Monnier [this message]
2013-09-12 15:54 ` [Emacs-diffs] trunk r114239: * vc/vc-svn.el (vc-svn-retrieve-tag): Mark unused argument Glenn Morris
2013-09-12 16:01 ` Glenn Morris
2013-09-12 19:11 ` Stefan Monnier
2013-09-12 19:32 ` Glenn Morris
2013-09-13 1:59 ` Stefan Monnier
2013-09-13 2:13 ` Glenn Morris
2013-09-13 14:35 ` Xue Fuqiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvppse1b2q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).