From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Fri, 29 Nov 2013 21:29:29 -0500 Message-ID: References: <871u1zes89.fsf@yandex.ru> <5298AA77.4060009@yandex.ru> <52991737.9000904@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385778584 8870 80.91.229.3 (30 Nov 2013 02:29:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Nov 2013 02:29:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 30 03:29:49 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmaJY-0000Wb-LU for ged-emacs-devel@m.gmane.org; Sat, 30 Nov 2013 03:29:49 +0100 Original-Received: from localhost ([::1]:50706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmaJW-0000wL-Bo for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 21:29:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmaJN-0000wB-FJ for emacs-devel@gnu.org; Fri, 29 Nov 2013 21:29:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmaJG-00087a-50 for emacs-devel@gnu.org; Fri, 29 Nov 2013 21:29:37 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:60076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmaJG-00087V-1S for emacs-devel@gnu.org; Fri, 29 Nov 2013 21:29:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJC6HcAbBLY0OAYN7A4hhnBmBXoMVgVE X-IPAS-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJC6HcAbBLY0OAYN7A4hhnBmBXoMVgVE X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40734996" Original-Received: from 206-248-161-33.dsl.teksavvy.com (HELO pastel.home) ([206.248.161.33]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Nov 2013 21:29:29 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 39E0C60EFA; Fri, 29 Nov 2013 21:29:29 -0500 (EST) In-Reply-To: <52991737.9000904@yandex.ru> (Dmitry Gutov's message of "Sat, 30 Nov 2013 00:37:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165917 Archived-At: >> I think of this "reminding" as a process rather than a one-time event, >> so I'm not too worried about it being "too late". >> It's not perfect, but it's better than nothing, I think. > If people not mentioning actual authors of contributed patches in ChangeLog > is a real problem (I'm not sure it is), how about augmenting the ChangeLog > font-locking instead, to highlight this field more prominently, prepend it > with ephemeral text "Author:", and/or add help echo that would remind them > that this field is for the actual author and their email. Note that a solution that applies only to ChangeLog wouldn't help for the `elpa' branch. And hopefully at some point it won't help for `emacs' either because we'll have finally rid ourselves of the ChangeLog files. > I've seen many times people include several entirely unrelated changes in > one commit. How does one write a summary line for them? That's the problem of the committer. The notion of "summary" is not my invention. It was there in GNU Arch, is there is Bzr, and is probably present in several other VCSes. > As long as point is after ":" when the buffer is created and `C-a' is bound > to `messge-beginning-of-line', I think the main drawback would be that it's > different from the other Git commit message edit interfaces I know (and > people might be used to), namely Vim and Magit. > Both of them implicitly consider the first line to be the summary, and they > indicate with highlighting when it exceeds 50 characters. We still also support the "first line is summary", for the sake of grumpy users, but that doesn't extend naturally to Author, Fixes, Amend, ... > Adding special, summary-header-targeted highlighting would improve > the situation. We could easily highlight Summary specially after the Nth character. [ Not sure why it should be 50, and that number might need to depend on the backend, but other than that, I don't see any particular difficulty. ] > Actually, now that I've checked, `C-c C-k' in both `message-mode' and > git-commit-mode' that Magit uses kill the buffer after doing some cleanup, > not bury it. Would you be fine with that? Seems a bit pointless since C-x k (and kill-this-buffer) works as well for *VC-Log*, AFAIK. > I think it can look better than using a separate window. But then again, > it's how other editors do it, so it might just be more familiar. I used a separate window because it seemed easier, avoiding the usual problems with display-only-text or with text-that-will-disappear, which both can lead to surprising behaviors for the unsuspecting user. Stefan