From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions Date: Wed, 18 Jun 2014 14:49:16 -0400 Message-ID: References: <21409.25893.932208.110667@home.barzilay.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1403117383 19293 80.91.229.3 (18 Jun 2014 18:49:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Jun 2014 18:49:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Barzilay Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 18 20:49:34 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WxKvM-0002hf-78 for ged-emacs-devel@m.gmane.org; Wed, 18 Jun 2014 20:49:32 +0200 Original-Received: from localhost ([::1]:60073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxKvL-0006WJ-Ot for ged-emacs-devel@m.gmane.org; Wed, 18 Jun 2014 14:49:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxKvC-0006RB-Vh for emacs-devel@gnu.org; Wed, 18 Jun 2014 14:49:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxKv7-0003vR-1w for emacs-devel@gnu.org; Wed, 18 Jun 2014 14:49:22 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxKv6-0003vK-UV for emacs-devel@gnu.org; Wed, 18 Jun 2014 14:49:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw/APYEXF3SCJQEBAQECAVYjBQsLNBIUGA0kLYdXCA3SDBMEjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw/APYEXF3SCJQEBAQECAVYjBQsLNBIUGA0kLYdXCA3SDBMEjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="67751430" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Jun 2014 14:49:16 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0AAE46608C; Wed, 18 Jun 2014 14:49:16 -0400 (EDT) In-Reply-To: <21409.25893.932208.110667@home.barzilay.org> (Eli Barzilay's message of "Wed, 18 Jun 2014 06:08:37 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172515 Archived-At: >> > * lisp/calculator.el: Lots of revisions >> > - Kill the calculator buffer after electric mode too. >> > - Make decimal mode have "," groups, so it's more fitting for >> > use in money calculations. >> > - Factorial works with non-integer inputs. >> > - Swallow less errors. >> > - Lots of other improvements, but no changes to custom >> > variables, or other user visible changes (except the above). >> The above description is the kind of thing that should go into >> etc/NEWS. > Shouldn't the NEWS entry list only user-visible changes? (That is, > only the first three items in the above.) That's right, I was mostly thinking of the first three (actually, the first one is probably not worth mentioning). >> But you forgot to include a ChangeLog entry for that commit. > Should I add it now? Yes, please. >> For the ChangeLog entry, you should instead include details about >> which parts of the code you changed (see >> https://www.gnu.org/prep/standards/html_node/Change-Logs.html). You >> can use "C-x 4 a" (both from the calculator.el and the *vc-diff* >> buffers) to help you write that. > (AFAICT, it doesn't help with the actual log message, right?) It's not intelligent, no, but it does write the file name and function name, using the proper syntax. > therefore the changelog file can be auto-generated. That's the end goal, yes. Stefan