From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Barzilay <eli@barzilay.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions
Date: Wed, 18 Jun 2014 14:49:16 -0400 [thread overview]
Message-ID: <jwvppi63vkp.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <21409.25893.932208.110667@home.barzilay.org> (Eli Barzilay's message of "Wed, 18 Jun 2014 06:08:37 -0400")
>> > * lisp/calculator.el: Lots of revisions
>> > - Kill the calculator buffer after electric mode too.
>> > - Make decimal mode have "," groups, so it's more fitting for
>> > use in money calculations.
>> > - Factorial works with non-integer inputs.
>> > - Swallow less errors.
>> > - Lots of other improvements, but no changes to custom
>> > variables, or other user visible changes (except the above).
>> The above description is the kind of thing that should go into
>> etc/NEWS.
> Shouldn't the NEWS entry list only user-visible changes? (That is,
> only the first three items in the above.)
That's right, I was mostly thinking of the first three (actually, the
first one is probably not worth mentioning).
>> But you forgot to include a ChangeLog entry for that commit.
> Should I add it now?
Yes, please.
>> For the ChangeLog entry, you should instead include details about
>> which parts of the code you changed (see
>> https://www.gnu.org/prep/standards/html_node/Change-Logs.html). You
>> can use "C-x 4 a" (both from the calculator.el and the *vc-diff*
>> buffers) to help you write that.
> (AFAICT, it doesn't help with the actual log message, right?)
It's not intelligent, no, but it does write the file name and function
name, using the proper syntax.
> therefore the changelog file can be auto-generated.
That's the end goal, yes.
Stefan
next prev parent reply other threads:[~2014-06-18 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Ww2Qw-0002aL-HF@vcs.savannah.gnu.org>
2014-06-16 21:22 ` [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions Stefan Monnier
2014-06-18 10:08 ` Eli Barzilay
2014-06-18 18:49 ` Stefan Monnier [this message]
2014-06-23 5:21 ` Eli Barzilay
2014-06-23 5:48 ` Nicolas Semrau
2014-06-23 14:24 ` Stefan Monnier
2014-06-18 15:21 ` Stefan Monnier
2014-06-22 12:23 ` Eli Barzilay
2014-06-23 13:24 ` Stefan Monnier
2014-06-24 7:47 ` Eli Barzilay
2014-06-25 1:11 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvppi63vkp.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eli@barzilay.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).