From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master ef75c3b: Optimize `file-equal-p' and `file-in-directory-p' in Tramp Date: Wed, 11 Nov 2015 09:40:07 -0500 Message-ID: References: <20151111104737.22161.11802@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447252851 6675 80.91.229.3 (11 Nov 2015 14:40:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Nov 2015 14:40:51 +0000 (UTC) Cc: Michael Albinus To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 11 15:40:43 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZwWZe-0003Av-Tk for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 15:40:35 +0100 Original-Received: from localhost ([::1]:41018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwWZe-00042N-18 for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 09:40:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwWZK-000425-Le for emacs-devel@gnu.org; Wed, 11 Nov 2015 09:40:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwWZF-0001Qy-2a for emacs-devel@gnu.org; Wed, 11 Nov 2015 09:40:14 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwWZE-0001QR-UC for emacs-devel@gnu.org; Wed, 11 Nov 2015 09:40:08 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CUDQA731xV/8uQWxdcgxCEAsEVh0sEAgKBPDoTAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgEBAQEeizqFBQcWhBcFi0RsqFQjgjuBWyCCeAEBAQ X-IPAS-Result: A0CUDQA731xV/8uQWxdcgxCEAsEVh0sEAgKBPDoTAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgEBAQEeizqFBQcWhBcFi0RsqFQjgjuBWyCCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="177789615" Original-Received: from 23-91-144-203.cpe.pppoe.ca (HELO pastel.home) ([23.91.144.203]) by ironport2-out.teksavvy.com with ESMTP; 11 Nov 2015 09:40:07 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 932BC602A7; Wed, 11 Nov 2015 09:40:07 -0500 (EST) In-Reply-To: (Michael Albinus's message of "Wed, 11 Nov 2015 10:47:38 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194060 Archived-At: > + (when (string-equal > + (file-remote-p (expand-file-name filename1)) > + (file-remote-p (expand-file-name filename2))) The above args to string-equal aren't always strings: why not use `equal' instead? (string-equal nil "nil") is non-nil, so I think the code will work correctly but only because file-remote-p should hopefully never return "nil". Stefan