From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 a9c48d5: Additional fixes for file notification Date: Mon, 29 Feb 2016 15:05:02 -0500 Message-ID: References: <20160222175244.30186.2617@vcs.savannah.gnu.org> <87k2lwv5ob.fsf@gmx.de> <87egc4v4hs.fsf@gmx.de> <8bd4ec21-1306-41bf-aca7-5571a3014337@default> <87r3g4js64.fsf@gmail.com> <2b98a5dd-7f46-4e92-9398-ede070c261de@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456776341 31566 80.91.229.3 (29 Feb 2016 20:05:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Feb 2016 20:05:41 +0000 (UTC) Cc: Emacs developers , John Wiegley , Michael Albinus , Oleh Krehel , Kaushal Modi To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 29 21:05:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aaU4O-000073-GP for ged-emacs-devel@m.gmane.org; Mon, 29 Feb 2016 21:05:28 +0100 Original-Received: from localhost ([::1]:38846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaU4N-0005xV-Th for ged-emacs-devel@m.gmane.org; Mon, 29 Feb 2016 15:05:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaU45-0005sB-T7 for emacs-devel@gnu.org; Mon, 29 Feb 2016 15:05:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaU40-0004y8-UK for emacs-devel@gnu.org; Mon, 29 Feb 2016 15:05:09 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaU40-0004wK-Qr; Mon, 29 Feb 2016 15:05:04 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0C0CwA731xV/96hCkxcgxBUXoJQwQwJgVKFeQQCAoE8ORQBAQEBAQEBgQpBBYNdAQEBAgFWIQIFCws0EhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBYwwinGcHoFFI4IKHIFwIDGCRwEBAQ X-IPAS-Result: A0C0CwA731xV/96hCkxcgxBUXoJQwQwJgVKFeQQCAoE8ORQBAQEBAQEBgQpBBYNdAQEBAgFWIQIFCws0EhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBYwwinGcHoFFI4IKHIFwIDGCRwEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="194733270" Original-Received: from 76-10-161-222.dsl.teksavvy.com (HELO pastel.home) ([76.10.161.222]) by ironport2-out.teksavvy.com with ESMTP; 29 Feb 2016 15:05:03 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 9B2B06224A; Mon, 29 Feb 2016 15:05:02 -0500 (EST) In-Reply-To: (Drew Adams's message of "Mon, 29 Feb 2016 10:11:10 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200824 Archived-At: > `cl-callf' > `cl-callf2' Don't have an opinion on those two. They might fit in gv.el. > `cl-iter-defun' This one could indeed move to generator.el, tho it currently uses the internal cl--transform-lambda, so the implementation would need to be rewoked to avoid having an external package depend on CL's internals. > `cl-flet*' This belongs right next to cl-flet, so moving it out of cl-lib would make no sense. > `cl-letf*' This belongs right next to cl-letf. > `cl-prettyprint' (called a "debugging aid") > `cl-prettyexpand' (called a "debugging aid") > `cl-describe-type' These are intimately linked to cl-lib's implementation, AFAIK. > Moving to `cl-preloaded.el': > `cl-struct-define' Same here. IOW they belong to cl-lib not because they're part of Common-Lisp, but because they belong to cl-lib's implementation. > And it seems that there are internal functions and macros, > which are used only for implementing CL things, which use > prefix `cl-' instead of `cl--'. For example, `cl-struct-define'. > Should they not be renamed? I don't have a strong opinion on this. The issue is the following: cl-struct-define is "used internally by cl-defstruct", but it can't be changed at will, because it will basically have to be preserved for as long as Emacs-NN.MM wants to be able to run .elc files generated with Emacs-24.5. Those "functions only used in a macro's expansion" have a half-way "internal" status in this respect, and we sometimes give them a "prefix-" and sometimes a "prefix--". Stefan