From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a Date: Thu, 21 Jul 2016 17:00:17 -0400 Message-ID: References: <20160721205319.22541.75336@vcs.savannah.gnu.org> <20160721205320.09141220159@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469134879 8833 80.91.229.3 (21 Jul 2016 21:01:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 21:01:19 +0000 (UTC) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 23:01:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQL5h-0007g1-QG for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 23:01:09 +0200 Original-Received: from localhost ([::1]:43712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL5h-0004B1-5t for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 17:01:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL3Y-0002zs-5x for emacs-devel@gnu.org; Thu, 21 Jul 2016 16:58:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQL3T-0001Yq-Uo for emacs-devel@gnu.org; Thu, 21 Jul 2016 16:58:55 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:47658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL3T-0001YN-Pf for emacs-devel@gnu.org; Thu, 21 Jul 2016 16:58:51 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u6LKxAiV016304; Thu, 21 Jul 2016 16:59:10 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9537A6025B; Thu, 21 Jul 2016 17:00:17 -0400 (EDT) In-Reply-To: <20160721205320.09141220159@vcs.savannah.gnu.org> (Mark Oteiza's message of "Thu, 21 Jul 2016 20:53:19 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5742=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5742> : inlines <5025> : streams <1671445> : uri <2252378> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205995 Archived-At: > - (add-function :override (local 'prettify-symbols-compose-predicate) > - #'tex--prettify-symbols-compose-p) > + (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p) Actually, I prefer the add-function version, as can be seen by the fact that I installed a patch which uses it. And if you look at the commit history, you'll see that I'm about as close to "maintainer of tex-mode.el" as there is, so please revert your reversion unless you have a concrete reason for it (not just "taste" on which we simply differ and neither can claim that the other one is wrong). Stefan