unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Mark Oteiza <mvoteiza@udel.edu>
Subject: Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a
Date: Thu, 21 Jul 2016 17:00:17 -0400	[thread overview]
Message-ID: <jwvpoq6pv47.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20160721205320.09141220159@vcs.savannah.gnu.org> (Mark Oteiza's message of "Thu, 21 Jul 2016 20:53:19 +0000 (UTC)")

> -  (add-function :override (local 'prettify-symbols-compose-predicate)
> -                #'tex--prettify-symbols-compose-p)
> +  (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p)

Actually, I prefer the add-function version, as can be seen by the fact
that I installed a patch which uses it.  And if you look at the commit
history, you'll see that I'm about as close to "maintainer of
tex-mode.el" as there is, so please revert your reversion unless you
have a concrete reason for it (not just "taste" on which we simply
differ and neither can claim that the other one is wrong).


        Stefan



       reply	other threads:[~2016-07-21 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160721205319.22541.75336@vcs.savannah.gnu.org>
     [not found] ` <20160721205320.09141220159@vcs.savannah.gnu.org>
2016-07-21 21:00   ` Stefan Monnier [this message]
2016-07-21 21:04     ` [Emacs-diffs] master b765164: ;Partially revert 2649105a Mark Oteiza
2016-07-21 21:14       ` Stefan Monnier
2016-07-21 21:15         ` Mark Oteiza
2016-07-22 18:26     ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpoq6pv47.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).