From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility with pre-existing struct instances. Date: Wed, 29 Mar 2017 08:26:10 -0400 Message-ID: References: <20170328192614.13038.29393@vcs0.savannah.gnu.org> <20170328192617.32EF32017F@vcs0.savannah.gnu.org> <86y3voh8wf.fsf@molnjunk.nocrew.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490790411 2561 195.159.176.226 (29 Mar 2017 12:26:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Mar 2017 12:26:51 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 29 14:26:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctCgV-0008Pq-Je for ged-emacs-devel@m.gmane.org; Wed, 29 Mar 2017 14:26:43 +0200 Original-Received: from localhost ([::1]:58868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctCgb-0001gx-L4 for ged-emacs-devel@m.gmane.org; Wed, 29 Mar 2017 08:26:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctCgV-0001gq-2d for emacs-devel@gnu.org; Wed, 29 Mar 2017 08:26:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctCgR-0003Al-Vb for emacs-devel@gnu.org; Wed, 29 Mar 2017 08:26:43 -0400 Original-Received: from [195.159.176.226] (port=52500 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctCgR-0003AO-PC for emacs-devel@gnu.org; Wed, 29 Mar 2017 08:26:39 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1ctCgG-00074I-Dw for emacs-devel@gnu.org; Wed, 29 Mar 2017 14:26:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:ySlzHP9N10G7HWK/byDPh4CzvhE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213496 Archived-At: > There's also a lingering FIXME that you added: > > (cl-defstruct (eieio--object > - (:type vector) ;We manage our own tagging system. > + (:type vector) ;; FIXME! ;We manage our own tagging system. > (:constructor nil) > > As far as I can see, the struct isn't used directly. Indeed, which is why it works despite the inconsistency. > These definitions are derived from it: eieio--object-class-tag, and > eieio--object-num-slot. The first just aref slot 0, and the second is 1. That's right. I put a FIXME because this inconsistency is ugly. I'm not completely sure how best to fix it, tho. Maybe just define those two accessors by hand. Stefan