From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fixing package-initialize, adding early init file Date: Wed, 21 Feb 2018 16:26:05 -0500 Message-ID: References: <838tc12h42.fsf@gnu.org> <834lmfdexa.fsf@gnu.org> <87vaeu40iz.fsf@tcd.ie> <87mv034gp5.fsf@tcd.ie> <87r2pfcvil.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519248415 32118 195.159.176.226 (21 Feb 2018 21:26:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Feb 2018 21:26:55 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 21 22:26:51 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eobuc-0007uu-CL for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 22:26:50 +0100 Original-Received: from localhost ([::1]:34868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eobwe-0001Kq-FF for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 16:28:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eobvU-0001Au-KE for emacs-devel@gnu.org; Wed, 21 Feb 2018 16:28:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eobu2-0003Rw-2s for emacs-devel@gnu.org; Wed, 21 Feb 2018 16:27:44 -0500 Original-Received: from [195.159.176.226] (port=45615 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eobu1-0003Qj-NT for emacs-devel@gnu.org; Wed, 21 Feb 2018 16:26:13 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eobrw-00032M-Nv for emacs-devel@gnu.org; Wed, 21 Feb 2018 22:24:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:0lX7wxqdHZ84YhvkNPfJIrmusag= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222969 Archived-At: > So then if you actually do want to run `package-initialize', you would > let-bind `package--within-init.el' to nil? I feel like that's a little > odd, since it would require you to introduce a workaround even if > `package-initialize' was only called once (i.e. you set > `package-enable-at-startup' to nil in early-init.el). Whereas with > what I suggested, you'd only need to introduce a workaround if > `package-initialize' was actually called twice. Clearly, we would not want to warn and/or skip one the first call (e.g. when the user set package-enable-at-startup to nil in early-init.el). > (If you were concerned about a warning being signaled after startup, > we could just condition it on `after-init-time' being nil.) That would work as well, yes, Stefan