* Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
[not found] ` <20180221213027.372932052F@vcs0.savannah.gnu.org>
@ 2018-02-21 22:04 ` Stefan Monnier
2018-02-26 2:33 ` Dmitry Gutov
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2018-02-21 22:04 UTC (permalink / raw)
To: emacs-devel; +Cc: Juri Linkov
> +(defcustom next-error-find-buffer-function nil
Why make it a defcustom rather than a defvar?
> + (when next-error-find-buffer-function
> + (funcall next-error-find-buffer-function avoid-current
> + extra-test-inclusive
> + extra-test-exclusive))
Could you arrange for the default value of this new *-function var not
to be nil so we can modify it with add-function?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
2018-02-21 22:04 ` [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom Stefan Monnier
@ 2018-02-26 2:33 ` Dmitry Gutov
2018-02-26 3:24 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Gutov @ 2018-02-26 2:33 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel; +Cc: Juri Linkov
On 2/22/18 12:04 AM, Stefan Monnier wrote:
>> +(defcustom next-error-find-buffer-function nil
>
> Why make it a defcustom rather than a defvar?
I think we'll want to provide a set of predefined functions in the
future, for the user to choose one from.
>> + (when next-error-find-buffer-function
>> + (funcall next-error-find-buffer-function avoid-current
>> + extra-test-inclusive
>> + extra-test-exclusive))
>
> Could you arrange for the default value of this new *-function var not
> to be nil so we can modify it with add-function?
Personally, I don't really expect this variable to be modified
programmatically. And if it is, most likely not in a "function
combination" fashion.
But, of course, I might be wrong.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
2018-02-26 2:33 ` Dmitry Gutov
@ 2018-02-26 3:24 ` Stefan Monnier
2018-02-27 21:39 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2018-02-26 3:24 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Juri Linkov, emacs-devel
>>> +(defcustom next-error-find-buffer-function nil
>> Why make it a defcustom rather than a defvar?
> I think we'll want to provide a set of predefined functions in the future,
> for the user to choose one from.
So a defcustom makes sense, good.
>>> + (when next-error-find-buffer-function
>>> + (funcall next-error-find-buffer-function avoid-current
>>> + extra-test-inclusive
>>> + extra-test-exclusive))
>> Could you arrange for the default value of this new *-function var not
>> to be nil so we can modify it with add-function?
> Personally, I don't really expect this variable to be modified
> programmatically. And if it is, most likely not in a "function
> combination" fashion.
But using `ignore` instead of `nil` both simplifies the code and makes
the var compatible with add-function, so it doesn't matter if
`add-function` is really useful with it.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
2018-02-26 3:24 ` Stefan Monnier
@ 2018-02-27 21:39 ` Juri Linkov
2018-02-27 22:13 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2018-02-27 21:39 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel, Dmitry Gutov
>>>> +(defcustom next-error-find-buffer-function nil
>>> Why make it a defcustom rather than a defvar?
>> I think we'll want to provide a set of predefined functions in the future,
>> for the user to choose one from.
>
> So a defcustom makes sense, good.
>
>>>> + (when next-error-find-buffer-function
>>>> + (funcall next-error-find-buffer-function avoid-current
>>>> + extra-test-inclusive
>>>> + extra-test-exclusive))
>>> Could you arrange for the default value of this new *-function var not
>>> to be nil so we can modify it with add-function?
>> Personally, I don't really expect this variable to be modified
>> programmatically. And if it is, most likely not in a "function
>> combination" fashion.
>
> But using `ignore` instead of `nil` both simplifies the code and makes
> the var compatible with add-function, so it doesn't matter if
> `add-function` is really useful with it.
So I just changed the default value from nil to ‘ignore’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
2018-02-27 21:39 ` Juri Linkov
@ 2018-02-27 22:13 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2018-02-27 22:13 UTC (permalink / raw)
To: Juri Linkov; +Cc: emacs-devel, Dmitry Gutov
> So I just changed the default value from nil to ‘ignore’.
Good, thanks,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-27 22:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180221213025.27066.69339@vcs0.savannah.gnu.org>
[not found] ` <20180221213027.372932052F@vcs0.savannah.gnu.org>
2018-02-21 22:04 ` [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom Stefan Monnier
2018-02-26 2:33 ` Dmitry Gutov
2018-02-26 3:24 ` Stefan Monnier
2018-02-27 21:39 ` Juri Linkov
2018-02-27 22:13 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).