From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Support custom 'null' and 'false' objects when parsing JSON Date: Thu, 07 Jun 2018 15:13:17 -0400 Message-ID: References: <874liea1r2.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528398726 357 195.159.176.226 (7 Jun 2018 19:12:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Jun 2018 19:12:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 07 21:12:02 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR0KH-0008OL-6B for ged-emacs-devel@m.gmane.org; Thu, 07 Jun 2018 21:12:01 +0200 Original-Received: from localhost ([::1]:59821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR0ML-0001kS-VF for ged-emacs-devel@m.gmane.org; Thu, 07 Jun 2018 15:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR0Li-0001kM-M0 for emacs-devel@gnu.org; Thu, 07 Jun 2018 15:13:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fR0Lf-0003tS-Fy for emacs-devel@gnu.org; Thu, 07 Jun 2018 15:13:30 -0400 Original-Received: from [195.159.176.226] (port=36652 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fR0Lf-0003qw-8D for emacs-devel@gnu.org; Thu, 07 Jun 2018 15:13:27 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fR0JV-0007e7-Tg for emacs-devel@gnu.org; Thu, 07 Jun 2018 21:11:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:1JrOhaKEw2rEXC7KdWJcav8bwso= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226098 Archived-At: > the keyword :null, I have to explicitly check for non-`nil'ness *and* > non-`:null'ness, whereas before only one check was necessary. Other IIUC this is a matter of changing things like (null x) to (memq x '(nil :null)) right? On this one example it doesn't look that bad, so I'm wondering about the real impact it would have on your code. > -json_to_lisp (json_t *json, enum json_object_type object_type) > +json_to_lisp (json_t *json, > + enum json_object_type object_type, > + Lisp_Object null_object, > + Lisp_Object false_object) Wouldn't it make sense to group those 3 parameters into a single object (presumably a pointer to a stack-allocated struct containing those 3 fields)? Stefan