From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 23 Oct 2018 13:14:02 -0400 Message-ID: References: <20151216202605.GA3752@acm.fritz.box> <83fuygcs5g.fsf@gnu.org> <56886E32.70305@yandex.ru> <83si2f9ve4.fsf@gnu.org> <56889EC3.3040108@yandex.ru> <877fjrkpdf.fsf@fencepost.gnu.org> <56892334.4000106@yandex.ru> <8760zakb7q.fsf@fencepost.gnu.org> <56892BDA.6060103@dancol.org> <871t9yk98g.fsf@fencepost.gnu.org> <568936F0.3060505@yandex.ru> <87wprqitj5.fsf@fencepost.gnu.org> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540314760 7699 195.159.176.226 (23 Oct 2018 17:12:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2018 17:12:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 23 19:12:36 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF0EN-0001tN-WB for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2018 19:12:36 +0200 Original-Received: from localhost ([::1]:43484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gF0GU-0007M8-IY for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2018 13:14:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gF0Fr-0007M0-G4 for emacs-devel@gnu.org; Tue, 23 Oct 2018 13:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gF0Fo-0001PV-Q4 for emacs-devel@gnu.org; Tue, 23 Oct 2018 13:14:07 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:36104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gF0Fo-0001P4-KW; Tue, 23 Oct 2018 13:14:04 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w9NHE2aF008349; Tue, 23 Oct 2018 13:14:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5B3EA6A487; Tue, 23 Oct 2018 13:14:02 -0400 (EDT) In-Reply-To: <83tvlcsnee.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 23 Oct 2018 18:17:29 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6402=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6402> : inlines <6939> : streams <1802160> : uri <2736411> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230594 Archived-At: >> Some time (two years) ago I volunteered to replace lots of the `pcase' >> occurrences in the Emacs sources (back) to cl-case where possible. You're suggesting changing (pcase X ('a (fooa)) ('b (foob)) ...) with (cl-case X (a (fooa)) (b (foob)) ...) ? >> Lots of people wanted this because they found understanding pcase >> expressions hard. In what sense is the above cl-case more clear than the pcase equivalent? I'm not saying the pcase version is better in those cases, but I think the respective advantages and disadvantages pretty much balance out. Stefan PS: In case anyone still doubts it, I'm opposed to replacing `pcase` uses with `cl-case` uses. I think it'd be at best a waste of time.