From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master dfed333: Remove fixnum restriction on some display vars Date: Fri, 24 May 2019 10:32:30 -0400 Message-ID: References: <20190522202917.27067.49863@vcs0.savannah.gnu.org> <20190522202920.3CA7920498@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243841"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 24 16:43:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hUBQJ-0011JU-70 for ged-emacs-devel@m.gmane.org; Fri, 24 May 2019 16:43:55 +0200 Original-Received: from localhost ([127.0.0.1]:55717 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUBQI-0006du-6O for ged-emacs-devel@m.gmane.org; Fri, 24 May 2019 10:43:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUBN7-0003oM-Ks for emacs-devel@gnu.org; Fri, 24 May 2019 10:40:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUBFK-0000yE-Dp for emacs-devel@gnu.org; Fri, 24 May 2019 10:32:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5324) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUBFK-0000xn-6p for emacs-devel@gnu.org; Fri, 24 May 2019 10:32:34 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BED82100C69; Fri, 24 May 2019 10:32:33 -0400 (EDT) Original-Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 822E5100A37; Fri, 24 May 2019 10:32:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558708352; bh=VyURVExJECEyoKfDEyM7YSsufg6G17vUZJi2QXnWa0o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kWK8vgno0qWopkUrHF0h1tYC52m77FPuzHrmOYobSIKSl30U8i+Bdm2ii7SSp4St9 jPdoqTHM8QZClt/eVlxqB5YMcV+NuQb2bnLOa+2omlQNgAQUWwaL3m4/39NOiSw7+b S3L5OsjSj8yZf7JfY/zmIFLbUF5LhrSPQ6vw2/uwkM8cPut3gz3ARzFhGpNvqn5Jp/ NbNhv2ARywcL9PjGlSOWOPq8J4sQNLqSV08W30Oj6yYATdyM5dp4m18sUkRGjPfsOn 2T8KE69G29UoAJDvH4RnEPNa/BYbNLHYIX2tTO0DFwLNwzF0PmqlJru2Y5tcrGNM3d a7p0ePLrcW7Kw== Original-Received: from alfajor (unknown [167.88.27.42]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 566871202F2; Fri, 24 May 2019 10:32:32 -0400 (EDT) In-Reply-To: (Paul Eggert's message of "Thu, 23 May 2019 12:57:54 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236960 Archived-At: >> Rather than convert to bignum, we should either crash or signal >> a `hallelujah` error, depending on whether you think this is due to >> a bug or too a supranatural power. > Crashing would be too strong, as one could then crash Emacs simply via (setq > tab-width (1+ most-positive-fixnum)). My comment was specifically about buffer-display-count (which counts a number of distinct heap objects). I haven't looked closely at the other cases, but this one jumped at me as a prime example where a fixnum is safe. Stefan