From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 29d1c72: Introduce new value t for compilation-context-lines to eliminate scrolling Date: Sun, 25 Aug 2019 14:39:46 -0400 Message-ID: References: <20190825102322.19558.22771@vcs0.savannah.gnu.org> <20190825102323.5080620CD5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122205"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alan Mackenzie To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 25 20:40:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1xRa-000VdO-FY for ged-emacs-devel@m.gmane.org; Sun, 25 Aug 2019 20:40:50 +0200 Original-Received: from localhost ([::1]:45660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1xRZ-0007k2-CK for ged-emacs-devel@m.gmane.org; Sun, 25 Aug 2019 14:40:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56521) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1xQj-0007jj-JX for emacs-devel@gnu.org; Sun, 25 Aug 2019 14:39:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1xQi-0000um-1b for emacs-devel@gnu.org; Sun, 25 Aug 2019 14:39:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61758) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i1xQh-0000to-Tu for emacs-devel@gnu.org; Sun, 25 Aug 2019 14:39:55 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9464A446C93; Sun, 25 Aug 2019 14:39:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 65460446C8D; Sun, 25 Aug 2019 14:39:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1566758388; bh=2bl+r3VSwcDN3AfK4ZsiohRd+NGf/Kn3TmwWNKyrLo4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ia1Cq9rJ9sSpgQW7Adi79V5NmWFsO3MWF9RuM86B69DxfviVDVJ2BPVm0kTdlwr6E 16UomplLxdBS3WxAMce0yL/Vbdw0Fa9SxCAzeVghVXafM/V3Lovu7AKACzlYa3TqBt IF/giiOqIG/TAR4C5Yfz83nFDwJT7fwVJRuO+qxTOBi0nVkS96a56ISwglTD48WuIO EAVgk9K7GP93xD+YBG061yg7MFEV2E7kNzgBJBF/OF7RGkd2OsbdJJkgC3o1rtcUS/ VHg/n7JLk3qJ+A+oAW8r3OasJNO8ZWjFd0+gQTh0sSpPLSjdJ88FOMwY3BX0j2rt2r g3c/wTnjgMu4Q== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DDD5C1203B2; Sun, 25 Aug 2019 14:39:47 -0400 (EDT) In-Reply-To: <20190825102323.5080620CD5@vcs0.savannah.gnu.org> (Alan Mackenzie's message of "Sun, 25 Aug 2019 06:23:22 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239556 Archived-At: Hi Alan, I have a few questions abut your change. > * lisp/progmodes/compile.el (compilation-context-lines): Add the new value t. > (compilation-set-window): Amend to handle compilation-context-lines being t. > (overlay-arrow-overlay): New variable holding an overlay with before-string > property "=>". 1- Why `overlay-arrow-overlay` without a `compilation-` prefix? 2- Why insert a prefix string (an "inserted arrow") instead of using a "regular overwriting arrow"? 3- Why link the choice of inserted-arrow vs regular-overwriting-arrow to compilation-context-lines specifically? -- Stefan "maybe part of my confusion is that I'm not sufficiently familiar with the behavior when there's no left-fringe"