From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119) Date: Wed, 25 Mar 2020 16:54:26 -0400 Message-ID: References: <20200325204155.5002.75177@vcs0.savannah.gnu.org> <20200325204157.3643820E43@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="126614"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 25 21:55:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHD3Q-000WqJ-A3 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Mar 2020 21:55:12 +0100 Original-Received: from localhost ([::1]:43230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHD3P-0001Y8-89 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Mar 2020 16:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42131) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHD2m-0000yk-Jd for emacs-devel@gnu.org; Wed, 25 Mar 2020 16:54:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHD2l-0004F7-65 for emacs-devel@gnu.org; Wed, 25 Mar 2020 16:54:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6786) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHD2k-0004El-W9 for emacs-devel@gnu.org; Wed, 25 Mar 2020 16:54:31 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 09C598122A; Wed, 25 Mar 2020 16:54:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 49F0F801AC; Wed, 25 Mar 2020 16:54:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1585169668; bh=Q/TDGL6pvGJMl4XNNKbpHBy+rNvsw8uov1XGHheRgaQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a6jUy7vg3YpGj9Vky74qezDiGdLRMId/P1YOlauQNBFRc7r2me+tn4EZCJ7yUMfvc /YVuobHdvr6sNcbuIQqZTYdC3XRqMnGI0x1QdaXpnspDTZ9PRJi/4RNuptI5e+6fa0 3lF/C8cuKwcnhapbBpijJSs3V+gJBU3BHvYcOQHpCuJf9t7ZQDQXFD6FfkP/9cvv0K oFUyqOAuwzf6cFRiElUp0DimrRl/KZKRVm+UQ4gZD4iAq980A7k3JLV5+vSGl+F4dM 6W2+tpr6QSSdrA9Getg2byACiW9bfxXidIw6rzYseh41IIS8oxFjHUL1CljLPbMewI +zdBYNCGtVEzg== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D2C7A12069F; Wed, 25 Mar 2020 16:54:27 -0400 (EDT) In-Reply-To: <20200325204157.3643820E43@vcs0.savannah.gnu.org> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Wed, 25 Mar 2020 16:41:56 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245792 Archived-At: > +(defcustom compilation-error-case-fold-search nil > + "If non-nil, use case-insensitive matching of compilation errors > +by the regexps of `compilation-error-regexp-alist' and > +`compilation-error-regexp-alist-alist'. > +If nil, matching is case-sensitive." > + :type 'boolean > + :version "28.1") This makes no sense as a user-config. The regular expressions are written either with or without case-folding in mind, so changing it globally is a recipe for problems. If we want to allow case-insensitive regexp matching, then we should extend the syntax of `compilation-error-regexp-alist` so that a given entry there can request it to be used with case-folding. Stefan PS: The same applies to the "zero/one-based column numbers" and the "char-colums vs visual-columns vs byte-columns", admittedly.