From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Move 'with-buffer-modified-unmodified' to simple.el Date: Wed, 16 Sep 2020 23:11:47 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36156"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 17 05:12:35 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIkLa-0009Js-FV for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Sep 2020 05:12:34 +0200 Original-Received: from localhost ([::1]:36064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIkLZ-0001XB-B2 for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Sep 2020 23:12:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIkL3-00016A-Tv for emacs-devel@gnu.org; Wed, 16 Sep 2020 23:12:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIkL1-0003Hd-Ch for emacs-devel@gnu.org; Wed, 16 Sep 2020 23:12:00 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B281F100279; Wed, 16 Sep 2020 23:11:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 10669100234; Wed, 16 Sep 2020 23:11:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600312309; bh=B0EU+rrChLpjXTgBOF5McMxJdwOIZ3CgO7PGVbqdZGk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YX0ev8ewy0N9j3tH8M18lXHoaZxL6tBE9I/ubX/7BjXk3LIPDI2l1GVb/5221Uf0G LMAP3d3AakebVYZdVgziyQWkj+vKEedXhaCxH+Q9WDbj74H/IzUxiK/TczD7uVT/32 WMZ6ansxlh36rPzPfJJ2MJJyxQ9PRtfMQfnfzQhVxcMAf2CsyEDKNZ3UZnoGe25rcJ NvuvLo3TR1orESgNsAbItLMG9viUdhx+kc0T38G79UzluWkYYG9XlVN6vvdhCCwqOX RNmYt/uYyyhl9gFveKPZEK+EPewHFgIaImW511XfXVSZ0KF70do6pR2COZ0zAuDo9h s6+Xm1OYbJdnw== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D441E1205CC; Wed, 16 Sep 2020 23:11:48 -0400 (EDT) In-Reply-To: (Yuan Fu's message of "Wed, 16 Sep 2020 19:12:05 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 23:11:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255948 Archived-At: > Currently it=E2=80=99s in bookmark.el. It seems to make more sense to be= in simple.el or sub.el. WDYT? Most use cases should be covered by `with-silent-modifications`, but there might indeed be cases as in bookmark.el where the extra bindings in `with-silent-modifications` aren't right. Could you look through our code (e.g. with something like grep '(set-buffer-modified-p' **/*.el | grep -v 'd-p \(nil\|t\))' ) to see where we could use `with-silent-modifications` and where only 'with-buffer-modified-unmodified' can be used? Stefan