From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 8f28a1b: Tweak `condition-case' keyword highlights Date: Sun, 24 Jan 2021 16:32:56 -0500 Message-ID: References: <20210124203118.16450.28084@vcs0.savannah.gnu.org> <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17175"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 24 22:34:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3n1Q-0004IY-Rs for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jan 2021 22:34:12 +0100 Original-Received: from localhost ([::1]:56136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3n1P-000648-UM for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jan 2021 16:34:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3n0I-0005bL-Rm for emacs-devel@gnu.org; Sun, 24 Jan 2021 16:33:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3n0G-0001a8-21 for emacs-devel@gnu.org; Sun, 24 Jan 2021 16:33:02 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7D9D880057; Sun, 24 Jan 2021 16:32:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 307C28024F; Sun, 24 Jan 2021 16:32:57 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611523977; bh=FfT6bs7HkAD5zuurdA9VCEgzvHMT9FwHcHkwR3X96sM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nwHG/Fi+WzbZbJLkLCBM2k2tql/Q93MGGd+ucxyglOvqkKahtEmt5EZr0hp629hdp zR6hw+pwt0qb2Oz2XXfJJVCE6fGu9UMq1MlV3o9kSShxtQFRrVNqQ/vRjcmE+7gdj0 MPSU7mYpcyV7eCNfyx2myFrJKhbEE6KJwlVyZmmDMwOG4+RVdFN2e2OmjSIxGR05vU lWwkh5B2iWF+KemB+jRwEvMOHJj5tRDJhntgHfFXUI6re4wiEZ8RwLoc0K6XyeMBF9 iiKDCqkBZW5XCA3bujVpl2c0h34FYZg6VMA1S8VxGpmCBUA2CtVg3Y+eot5RdRvaIn Ap3WRu599OjYA== Original-Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DD0F4120202; Sun, 24 Jan 2021 16:32:56 -0500 (EST) In-Reply-To: <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 24 Jan 2021 15:31:19 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263357 Archived-At: > +(ert-deftest test-elisp-font-keywords-5 () > + (should (eq (test--font '(condition-case (when a) > + (foo) > + (error t)) > + "(\\(when\\)") > + nil))) FWIW, I'd be just as happy if `when` were highlighted with a keyword face in this case: it's invalid code anyway, so the only highlighting that would actually be helpful is one with some kind of error/warning face, but I think it's best to leave it to `flymake-mode` to do that for us. Stefan