From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 8f28a1b: Tweak `condition-case' keyword highlights
Date: Sun, 24 Jan 2021 16:32:56 -0500 [thread overview]
Message-ID: <jwvpn1um39a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 24 Jan 2021 15:31:19 -0500 (EST)")
> +(ert-deftest test-elisp-font-keywords-5 ()
> + (should (eq (test--font '(condition-case (when a)
> + (foo)
> + (error t))
> + "(\\(when\\)")
> + nil)))
FWIW, I'd be just as happy if `when` were highlighted with a keyword
face in this case: it's invalid code anyway, so the only highlighting
that would actually be helpful is one with some kind of error/warning
face, but I think it's best to leave it to `flymake-mode` to do that for us.
Stefan
next parent reply other threads:[~2021-01-24 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210124203118.16450.28084@vcs0.savannah.gnu.org>
[not found] ` <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org>
2021-01-24 21:32 ` Stefan Monnier [this message]
2021-01-24 21:45 ` master 8f28a1b: Tweak `condition-case' keyword highlights Lars Ingebrigtsen
2021-01-24 22:07 ` [External] : " Drew Adams
2021-01-24 22:50 ` Lars Ingebrigtsen
2021-01-24 23:10 ` Stefan Monnier
2021-01-26 0:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpn1um39a.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).