From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Thu, 04 Mar 2021 09:50:05 -0500 Message-ID: References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> <87blbzd70v.fsf@tcd.ie> <87pn0frqd3.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 16:06:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHpYn-0007Lt-VT for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 16:06:41 +0100 Original-Received: from localhost ([::1]:43870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHpYm-00035c-UT for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 10:06:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHpIo-0003pW-U3 for emacs-devel@gnu.org; Thu, 04 Mar 2021 09:50:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHpIm-0000Ds-Rc for emacs-devel@gnu.org; Thu, 04 Mar 2021 09:50:10 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D4B8480229; Thu, 4 Mar 2021 09:50:07 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CFD93801AB; Thu, 4 Mar 2021 09:50:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614869405; bh=E5CaDukC2nTtPuez0JH+pJd9E4hIg6cVo5u+yNM5TDU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=it+w1Y/ebMtUb+FIDZqoZKQFj5qbJkebT8Ro9Dtj04a5OIdACf25nMFUTG4vWl45y wlW53t1xBqshYFJhD+M0PeHpn+4bsb9W73+Q7pSfkvnQ+Szm0sTYRDsXYnwHa0Zfyu dflwc9f6BVbtaieuFdGrmdhLgK/XfXqfRHcbCfNFjz4Cje8x+O9z866vo1upcwnNS0 jGr3OReRqHQUmKHghGiGHBwdmzJuA+5d1kbmbtkC4Xnfw/W/pyZIIb6Q9E2nmGGI3K +Vn6OwRO5bAQAMYd57W//QZXhXyAbxly47oPkGAJc4dAvlrSpfEMMTc0uVHDpj0rWs HtHsbQLvIFRiQ== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9BD2D12034D; Thu, 4 Mar 2021 09:50:05 -0500 (EST) In-Reply-To: <87pn0frqd3.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 04 Mar 2021 13:38:16 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265960 Archived-At: >>> Beats me :/. Even after reverting commits a0f60293d9 and 88ca2280ba, >>> 'make check' still fails. But both 'git bisect', and checking out its >>> parent 6ad9b8d677, point to a0f60293d9 as being the culprit. >> It turns out it was because a `no-byte-compile` was hiding the problem. > Sometimes I feel like the compiler doesn't ignore our comments. I have no doubt we are being watched, Stefan