From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 16:01:14 -0400 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> <87r1hviwrw.fsf@gmail.com> <87mtsibwjz.fsf@mail.linkov.net> <87pmxeg19e.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , Daniel Mendler , emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 22:02:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lldGM-0000cH-1H for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 22:02:50 +0200 Original-Received: from localhost ([::1]:48170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lldGL-0005FU-3H for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 16:02:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldEv-0004K6-29 for emacs-devel@gnu.org; Tue, 25 May 2021 16:01:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldEs-0007lA-Fz for emacs-devel@gnu.org; Tue, 25 May 2021 16:01:20 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0C57E4412E2; Tue, 25 May 2021 16:01:17 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A8D2E4412DB; Tue, 25 May 2021 16:01:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621972875; bh=02jB/vlHrIAzcUeNOPQStj29ThdWa4azVGGB3ifmE7U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kh4kPA6ze2aSCVumk9TxMsnU5RpwPuDNX1I/JNSZI7sXYCYI7PtqR14KvhtRmbkFm 4s9r/YsVSunlISmnpZbJ+EHW210yuu/XAnSnZL78v8vzaM80CbZEHTGVGvydT7sBOL VgHchFeBT82k/bsn+ZvQYK7JCTWjkmiLELB5LSA6ELpBli7yj0PHZkeV0yaCnEqynO OvrgoSugL7Zrvm77QlB09rIPPUgfNmAXTuxoYXsOCdjKL2DZn+VwQtWY0LCjVSnvO6 Q+7yvYXBi9Mi0+Hb8I/RJZGqdDyBLBOf3RRVSP4XcOw+ErRdeTZhY0DdxKsG3kZrDD kxtUPfZirs3aw== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 700971207BE; Tue, 25 May 2021 16:01:15 -0400 (EDT) In-Reply-To: <87pmxeg19e.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Tue, 25 May 2021 18:40:45 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269891 Archived-At: > I see, broken windows. You keep asking for good API's but when things > are proposed in that direction "that's good" but doesn't matter. [ Remember that the whole design of Emacs and ELisp goes against the usual software engineering practice of using encapsulation and abstraction to modularize the code so that one part can't mess with the other. Instead, Emacs's idea of empowering users means that for one part to be able to mess with another is considered a feature rather than a bug, and the "abstraction boundaries" are enforced by conventions rather than by technical means. As a dependent-types kinda guy, I sometimes find it odd as well, but I think it has served Emacs surprisingly well, so I tend to try and keep following the same design, despite my natural leaning against it. ] > As to the current shape affixation-function, I'm not mortally against it > just that its misdesign is a bit jarring, but so are so many other parts > of the completion system, so I guess, broken windows. It's just that > this is supposed to be a new part. The part of `affixation-function` which I find problematic is the fact that it does the layout itself, whereas I think it would be better to do it in the UI (so it can choose to use columns or not, to put it at the beginning or at the end, etc...). The fact that it takes a whole list rather than a single element is more in the "bikeshedcolor" category for me. Stefan