From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Context menus and mouse-3 Date: Mon, 12 Jul 2021 23:01:13 -0400 Message-ID: References: <20200914061111.3trmuzhdvv7nwdcc@Ergus> <87y2acv2tw.fsf@mail.linkov.net> <87sg0jt7bo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Richard Stallman , spacibba@aol.com, philipk@posteo.net, emacs-devel@gnu.org, arthur.miller@live.com, dgutov@yandex.ru, ghe@sdf.org, drew.adams@oracle.com To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 13 05:02:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m38gl-0007V2-Mj for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Jul 2021 05:02:27 +0200 Original-Received: from localhost ([::1]:44040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m38gk-0002Db-Mr for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jul 2021 23:02:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m38fh-00017n-Rd for emacs-devel@gnu.org; Mon, 12 Jul 2021 23:01:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m38fe-0001x8-P1; Mon, 12 Jul 2021 23:01:20 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F1E4A80B63; Mon, 12 Jul 2021 23:01:15 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9CBBB808D9; Mon, 12 Jul 2021 23:01:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1626145274; bh=dCUXwdEdOwH1DNDAhwcc2CsOgLc+PdfVfzdc8WdZaFs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gllPdS8/JZH1bd9vw39O20fQMLA3tYhXaneycFa/MR/oKu47rXNqs4bRtK+VtMEJv F8bYPttHY5TGAokjXtZUgwjozKmZzUbV40OKpgGlTLFiNguN/FDYsD/+Y9GhfNi+th S8zPJRA/EggHWs7dzzkETKONTZF0fkG4D+CG/ztOv7snj3aVNPF+dXKzZxLetnfCdf AknxBIcrMNpwvfrnQ+iMxqt0836FyW3jT7zNce79LAtT9n/a6Gmx/TROFW9+RF1tZ3 yZnUxTHhgZ11foU+YkpI4LR5Ve8gwlNvJXrBNl/Bd4b/Hb/IQnFiMiB0y4niGMyQsv OYLirZ3FD2WZQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 434481202DA; Mon, 12 Jul 2021 23:01:14 -0400 (EDT) In-Reply-To: <87sg0jt7bo.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 13 Jul 2021 02:56:27 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271192 Archived-At: >>> The global binding of [menu-bar] is defined in menu-bar.el, >>> so the same way [context-menu] could be defined globally >> Agreed, and I think it would address the above problem. >> I.e. do something like >> >> (defun mouse-context-menu (event) >> (push `(context-menu . ,(cdr event)) unread-command-events)) > > OT1H, this avoids an explicit call to 'popup-menu'. Calling `popup-menu` is not a problem, but not doing the dance usually done by the command loop is more problematic. > But OTOH, this precludes constructing the context-menu with > a user-defined function mouse-context-menu-function. Actually it doesn't. You can bind `context-menu` to a command that uses that function and then passes the result to `popup-menu`, or you can bind it to something like `(menu-item "Context menu" ignore :filter (lambda (_) ..call mouse-context-menu-function..)) > I tried to override the global [context-menu] with e.g. menu-bar-custom-menu > (that later could be replaced with the value returned from mouse-context-menu-function): > > (let ((map (make-sparse-keymap))) > (define-key map [context-menu] menu-bar-custom-menu) > (set-transient-map map)) > (push (cons 'context-menu (cdr event)) unread-command-events) > > However, it doesn't override the global [context-menu], but prepends > the transient [context-menu] before the global one. Yes, if the key is bound in various keymaps and all the bindings are to a keymap, then those keymaps get merged, as usual for prefix keymaps. Two ways to solve that: - use `mouse-context-menu-function` instead of adding a new local key binding for `context-menu`. - don't bind `context-menu` to a keymap but to a command (that presumably then uses `popup-menu` internally). >> PS: FWIW, the "proof of concept" code I have in my local Emacs is: > [...] >> I think `sit-for` can be made to work OK, but my proof-of-concept >> isn't good enough. I think the main issue is that it doesn't >> swallow the mouse-3 click, but I haven't really looked into it. > > At least, now we have two implementations, and both could be improved > before selecting the one that works better. FWIW I think yours holds more promise, so I don't intend to try and improve mine. Stefan