unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package
       [not found] ` <20210807231109.E658220BD3@vcs0.savannah.gnu.org>
@ 2021-08-08  3:24   ` Stefan Monnier
  2021-08-08  8:00     ` Philip Kaludercic
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2021-08-08  3:24 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: emacs-devel

Philip Kaludercic [2021-08-07 19:11:09] wrote:
> + ("smartparens"		:url "https://github.com/Fuco1/smartparens"
> +  :ignored-files ("dev" "doc" "images" "test")
> +  ;; See https://github.com/Fuco1/smartparens/releases/tag/1.11.0
> +  :version-map ((nil "1.11.0" "4873352b5d0a1c5142658122de1b6950b8fe7e4d")))

Thanks Philip,

Even better than this URL would be a link to an issue/bugreport
requesting the version number be added in the file.


        Stefan




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package
  2021-08-08  3:24   ` [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package Stefan Monnier
@ 2021-08-08  8:00     ` Philip Kaludercic
  2021-08-19  9:23       ` Philip Kaludercic
  0 siblings, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2021-08-08  8:00 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Philip Kaludercic [2021-08-07 19:11:09] wrote:
>> + ("smartparens"		:url "https://github.com/Fuco1/smartparens"
>> +  :ignored-files ("dev" "doc" "images" "test")
>> +  ;; See https://github.com/Fuco1/smartparens/releases/tag/1.11.0
>> +  :version-map ((nil "1.11.0" "4873352b5d0a1c5142658122de1b6950b8fe7e4d")))
>
> Thanks Philip,
>
> Even better than this URL would be a link to an issue/bugreport
> requesting the version number be added in the file.

I'll update both the smartparens and the haskell-mode package
specification to add those links.

>
>         Stefan
>

-- 
	Philip Kaludercic



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package
  2021-08-08  8:00     ` Philip Kaludercic
@ 2021-08-19  9:23       ` Philip Kaludercic
  2021-08-19 13:08         ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2021-08-19  9:23 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Philip Kaludercic <philipk@posteo.net> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> Philip Kaludercic [2021-08-07 19:11:09] wrote:
>>> + ("smartparens"		:url "https://github.com/Fuco1/smartparens"
>>> +  :ignored-files ("dev" "doc" "images" "test")
>>> +  ;; See https://github.com/Fuco1/smartparens/releases/tag/1.11.0
>>> +  :version-map ((nil "1.11.0" "4873352b5d0a1c5142658122de1b6950b8fe7e4d")))
>>
>> Thanks Philip,
>>
>> Even better than this URL would be a link to an issue/bugreport
>> requesting the version number be added in the file.
>
> I'll update both the smartparens and the haskell-mode package
> specification to add those links.

It has been requested to remove haskell-mode for now, because the
maintainers are not sure how their release procedure interacts with
ELPA:
https://github.com/haskell/haskell-mode/issues/1755#issuecomment-896127958

Would there be any issue in just commenting the specification out?

>>
>>         Stefan
>>

As a side-note, would be make sense to extend elpa-admin to handle git
tags if requested?

-- 
	Philip Kaludercic



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package
  2021-08-19  9:23       ` Philip Kaludercic
@ 2021-08-19 13:08         ` Stefan Monnier
  2021-08-19 15:31           ` Philip Kaludercic
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2021-08-19 13:08 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: emacs-devel

> Would there be any issue in just commenting the specification out?

Not that I can think of.

> As a side-note, would be make sense to extend elpa-admin to handle git
> tags if requested?

No, because tags from one package would collide with tags from
other packages.


        Stefan




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package
  2021-08-19 13:08         ` Stefan Monnier
@ 2021-08-19 15:31           ` Philip Kaludercic
  2021-08-20 21:49             ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2021-08-19 15:31 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Would there be any issue in just commenting the specification out?
>
> Not that I can think of.

Ok, I'll update that then until the upstream repo changes their mind.

>> As a side-note, would be make sense to extend elpa-admin to handle git
>> tags if requested?
>
> No, because tags from one package would collide with tags from
> other packages.

I see. There might be the possibility of checking the remote repository
for new tags, without having to clone these into the repository
itself. According to [0] the command

        git ls-remote --tags </url/to/upstream/repo>

could generate such a listing. And in fact,

$ git ls-remote --tags https://github.com/haskell/haskell-mode
e72677668f5fc7cc148008e885a0f256e245dd43	refs/tags/17.2
8c49232e5e507cd978aaa5a33cbf8dda7b43518f	refs/tags/2_5_1
72d395fc5fe49834116c0aaeb25d1731fa47d72c	refs/tags/2_5_1^{}
22a963b80c32cd9c16f804341cdbe41c801470e8	refs/tags/2_6
4a16cc3367aa067a71d8dd74bab1d6de45b09bfa	refs/tags/2_6^{}
753421777852b0dde5c8f899ccbd6920c10f2f43	refs/tags/2_6_1
...

gives me a list of commits and tags, that could be sorted to find the
newest version.

[0] https://stackoverflow.com/a/25987962

>
>         Stefan
>

-- 
	Philip Kaludercic



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package
  2021-08-19 15:31           ` Philip Kaludercic
@ 2021-08-20 21:49             ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2021-08-20 21:49 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: emacs-devel

> I see. There might be the possibility of checking the remote repository
> for new tags, without having to clone these into the repository
> itself. According to [0] the command

I don't want the act of building the tarballs to depend on info which is
not available in the elpa/nongnu Git repository itself.


        Stefan




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-20 21:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210807231108.10378.42095@vcs0.savannah.gnu.org>
     [not found] ` <20210807231109.E658220BD3@vcs0.savannah.gnu.org>
2021-08-08  3:24   ` [nongnu] main 23c23ad: * elpa-packages (smartparens): Add package Stefan Monnier
2021-08-08  8:00     ` Philip Kaludercic
2021-08-19  9:23       ` Philip Kaludercic
2021-08-19 13:08         ` Stefan Monnier
2021-08-19 15:31           ` Philip Kaludercic
2021-08-20 21:49             ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).