From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sat, 12 Feb 2022 14:15:54 -0500 Message-ID: References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35105"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 12 20:17:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIxtW-0008sr-MA for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 20:17:18 +0100 Original-Received: from localhost ([::1]:52862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIxtV-0004gM-5Q for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 14:17:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIxsJ-0003zK-Gr for emacs-devel@gnu.org; Sat, 12 Feb 2022 14:16:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIxsG-0007B8-Aw; Sat, 12 Feb 2022 14:16:02 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5954B100211; Sat, 12 Feb 2022 14:15:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 22EAF100124; Sat, 12 Feb 2022 14:15:57 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644693357; bh=2f9IrYp5kPGTuFrRfT0hnz+SfENXGyg8IzCxoQuaifQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cquZ5DFjUQ87cTyrytpBFpqzFU6oHJjczIFHGBKT45s+rXyMRv0Sa68EuuQ5cMYh3 FwWuh3Bzxt1kOCgF24gyaSoX9tqp9V1gpntmPJ35YtjYLC6o6GdFQQq/GAmIdl9x34 xRyDYXgfKch6a0By+6ZKDGY/BOFl3AKgWvTc9dAGyPbqz1mvRZ9S1FIvhWrHayamc1 AsJRv2P+pPpx/yAVTxa0dp0IPFsDKuKDcqstt2aGR77LfsGSGDTFyeUxv8I3B+N+hH 51d+x7QmV+wMEIprsIMHdDzMgLE/1d4Wcu0o4jMEKCn9pnWET2bUJSkHdkpOYpUzXy zR4xtu1DziqLg== Original-Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E5A5A1202E6; Sat, 12 Feb 2022 14:15:56 -0500 (EST) In-Reply-To: <83y22frjpy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Feb 2022 21:03:05 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286191 Archived-At: >> > * lisp/ls-lisp.el (ls-lisp-format, ls-lisp-format-file-size): The >> > human-readable file sizes can be 7 characters wide (e.g., >> > "1016.1k") (bug#53937). >> >> Why would we want the ".1" in "1016.1k"? > > See file-size-human-readable. I know. And I'm asking why `file-size-human-readable` gives so much accuracy. > (IOW, this has nothing to do with ls-lisp.) Agreed. Stefan