From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master af0ea35ea0: Tweak how functions are formatted in Implementation in *Help* Date: Thu, 31 Mar 2022 14:12:41 -0400 Message-ID: References: <164872671963.30191.4037902323881017518@vcs2.savannah.gnu.org> <20220331113841.3BBFAC0581F@vcs2.savannah.gnu.org> <87pmm2qnkl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23635"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Lars Ingebrigtsen To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 31 20:37:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzfu-0005wJ-3k for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Mar 2022 20:37:38 +0200 Original-Received: from localhost ([::1]:34948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZzft-0003mp-7t for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Mar 2022 14:37:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZzHw-0000or-GO for emacs-devel@gnu.org; Thu, 31 Mar 2022 14:12:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZzHt-0000wC-RT for emacs-devel@gnu.org; Thu, 31 Mar 2022 14:12:51 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 504BF10022E; Thu, 31 Mar 2022 14:12:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 56C9E100163; Thu, 31 Mar 2022 14:12:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1648750365; bh=3imhBVdYJgF5LvPw444WPczGX5W9VT6hDxqVEDpWK6s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QXROqZ9brJlIziWGnomWvEEH9jI9VqTwL/iA1b+fRuTaKTMPyBFhVhSi6YsO3bDVt jiWpr6SBw6G1nYmup4/mBesBA/b81hYVnXwe4eqDvmPgS4esouZ6TTLGDp8n/wWjfw 7vq11zQ+KHIjs8G0Rnxn6fa4UJj7SYPr7Ne8WWvxiHJIOdJpsP7tYDGOPI0wv3DpLV U3QLACFYHPqsga4+AjzU0dluNZt/93hwy0DkgFjqPZs1su4T5UFH7Zm1+a5IFbsa3m qnT+V9dAVCrEb8Ltc4e7NJR6Wa50DNqcMB4m403RW2nQwJoHEQg4ZBBBEgKPg8BKtL mMaPkm8iIwB9g== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4E56E120175; Thu, 31 Mar 2022 14:12:45 -0400 (EDT) In-Reply-To: <87pmm2qnkl.fsf@gmail.com> (Robert Pluim's message of "Thu, 31 Mar 2022 15:05:46 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287638 Archived-At: > Lars> @@ -1098,7 +1098,7 @@ MET-NAME is as returned by `cl--generic-l= oad-hist-format'." > Lars> (dolist (method (cl--generic-method-table generic)) > Lars> (let* ((info (cl--generic-method-info method))) > Lars> ;; FIXME: Add hyperlinks for the types as well. > Lars> - (insert (format "%s%S" (nth 0 info) (nth 1 info))) > Lars> + (insert (format "%s%S" (nth 0 info) (cons function= (nth 1 info)))) > > Is it worth applying `upcase' to the (nth 1 info) so the result looks > more like C-h f output? If so, we should be careful to only apply it to the argnames but not to the specializers since these are case sensitive. The above patch also leads to odd results for methods with qualifiers. E.g. `C-h o cl-generic-generalizers RET` shows things like: :extra "cl-struct" (cl-generic-generalizers type) in =E2=80=98cl-generi= c.el=E2=80=99. Undocumented which I find rather confusing. I understand the motivation for the change, but I'm not sure it's an improvement. (and I don't know what would be a good way to combine the qualifiers with the function name). Stefan