From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Fri, 29 Apr 2022 12:18:18 -0400 Message-ID: References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> <87zgk42day.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27185"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Juri Linkov , emacs-devel@gnu.org To: James N. V. Cash Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 18:39:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkTe9-0006rF-Tu for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 18:39:10 +0200 Original-Received: from localhost ([::1]:43886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkTe8-0001AR-SY for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 12:39:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkTKR-0003lj-4W for emacs-devel@gnu.org; Fri, 29 Apr 2022 12:18:47 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkTKN-0006QH-DX for emacs-devel@gnu.org; Fri, 29 Apr 2022 12:18:45 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 184164424BC; Fri, 29 Apr 2022 12:18:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7657B4424BA; Fri, 29 Apr 2022 12:18:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651249101; bh=Dd+3nfOJ4/2HfslVwzwx8mljoFifMnYA2/QWUGPr4JQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OcwByF6xqVDBa7wUC+GFo4QuapjgOsk6rTOjVW+Qq6kLU27nn7izloHyuJOElrm/y jHtYHjjdlWD5ZOSnCj+vks6i35cOrUnBIJWUn8RuVJFA6xlZGuR2IO0zFkDNRcxy6q vy78Aa1xf4I0Vab7Kn4uH1v153lzI4QqAF05KWWbd7sOLSXEiPXGrssXZiz9eKNCB8 3Af3QHOHhJ+HqgQa7p5cOLbuKBZThPInkeBgB3aebjPaawj2bhBsA4Gs/Dt2Wgi/HH QOPLzoZ26jTq7NWsqT11E4z/obQw7LTxNY3JcSj1z2ePmaY+zgXfiDMaVW0J9H0pkC ZfPKr33+zCyCA== Original-Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AFD2F120600; Fri, 29 Apr 2022 12:18:20 -0400 (EDT) In-Reply-To: <87zgk42day.fsf@occasionallycogent.com> (James N. V. Cash's message of "Fri, 29 Apr 2022 10:07:33 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289009 Archived-At: James N. V. Cash [2022-04-29 10:07:33] wrote: > Stefan Monnier writes: >>> + (let ((beg (if (number-or-marker-p beg) >>> + beg >>> + (save-excursion >>> + (goto-char (minibuffer-prompt-end)) >>> + (search-forward beg)))) >>> + (end (if (number-or-marker-p end) >>> + end >>> + (save-excursion >>> + (goto-char (point-max)) >>> + (search-backward end))))) >> >> What if there are several matches for `beg` and/or for `end` in >> the buffer? How do we know we got the intended one? > > A good question; as far as I can tell though, `beg` and `end` are only > strings when called via `choose-completion` in `simple.el`, when it > passes in `base-affixes`. `base-affixes` is in turn set to > `completion-base-affixes`, which gets set in > `minibuffer-completion-help`. There, the value that becomes `beg` is > `(buffer-substring (minibuffer--completion-prompt-end) (+ start base-size))` > and `end` is `(buffer-substring (point) (point-max))`, so I think that changing > `minibuffer-prompt-end` in my patch to > `minibuffer--completion-prompt-end` would suffice to ensure that it is > always matching from the correct point to match the intended positions. I think rather than (minibuffer--completion-prompt-end) and (point-max), we should be using "the beginning of the completion area" and "the end of the completion area". In a typical minibuffer completion, that's exactly the same, but in `completing-read-multiple` or `complete-in-region` the difference can be significant. Stefan