From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master e8488bcc9c: Avoid having font locking triggering unnecessary auto-saving Date: Mon, 09 May 2022 22:11:41 -0400 Message-ID: References: <165191796540.22789.3432288633082546349@vcs2.savannah.gnu.org> <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org> <87fsli7uhf.fsf@gnus.org> <87bkw67rru.fsf@gnus.org> <8735hi7r7k.fsf@gnus.org> <87ilqe4roc.fsf@gnus.org> <83levau0r4.fsf@gnu.org> <87v8ue3b9g.fsf@gnus.org> <87mtfq38r3.fsf@gnus.org> <87k0aunohy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22051"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 10 04:12:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noFMV-0005Xv-54 for ged-emacs-devel@m.gmane-mx.org; Tue, 10 May 2022 04:12:31 +0200 Original-Received: from localhost ([::1]:56110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noFMT-0002io-Qo for ged-emacs-devel@m.gmane-mx.org; Mon, 09 May 2022 22:12:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noFLo-000241-3I for emacs-devel@gnu.org; Mon, 09 May 2022 22:11:48 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noFLl-0005Uh-Tj; Mon, 09 May 2022 22:11:47 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BCEDA1001CB; Mon, 9 May 2022 22:11:44 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 72664100118; Mon, 9 May 2022 22:11:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1652148703; bh=Yi+0YOvzJAD6DVHKw033NbXLzbp8iXZJLKrzAkebv5U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=horG0znWM+Bx7SH/wDe/YHhN4ZANRo/c4HDXRz5fbUDAwP5+GzxThUDx/09xxULUc d+Qn3BOUmMXkQSpsdK1oQnDJbZIgcN0GYIkRr0jCT+LgzFykCP5DCgO3eaCmQyzel5 VlkZ/dQIhjxTP5lUCZFy6IkyRW9+wPpaqK9DAzgu2hAT7eb39+I6D5jjMp/ZgUn5SK mV2Elhb9OOAJYx4USY1eZJHWOKUKASz6SDl9JdtWCX4EUMczKHNtbE9VBNaq8YIHyt Mm197IHLPJdBv0B7bCPBCon1SClh/uEC4VNMuA0KWAVxxNV3/FnyijzPuAu92Hnc7s ZT+Y88USozxog== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 443C1120549; Mon, 9 May 2022 22:11:43 -0400 (EDT) In-Reply-To: <87k0aunohy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 10 May 2022 03:51:53 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289565 Archived-At: >> [ I'd use `(unless (eq ,modified t)` ] > The return value is now defined as nil/`autosaved'/non-nil, so assuming > t is no longer the thing. :-) >> But... hmm... what if `body` caused the modified-p status to change from >> `autosaved` to `nil`. With the old code, we'd leave `nil` untouched, >> but with the new code we'd re-set it to `autosaved`. >> >> Admittedly, it's quite unlikely for `body` to save the buffer (and hence >> cause the modified-p status to change from `autosaved` to `nil`), so I'm >> not sure how important this is. > > I think that's probably outside the scope for this macro. Fair enough. In that case, maybe it can even call `restore-buffer-modified-p` unconditionally. >> I think this will not do the right thing if you call >> `(restore-buffer-modified-p 'autosaved)` when modified-p is `nil`. > > Yeah, the semantics are slightly obscure now, but you're not supposed to > call the function with `autosaved' when it hasn't been modified. > Perhaps it should just signal an error in that case? Why not make it DTRT and make sure (buffer-modified-p (restore-buffer-modified-p FLAG)) always returns FLAG if FLAG is one of nil/t/autosaved (and add a few tests while we're at it)? Stefan