unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org,  emacs-devel@gnu.org,  eggert@cs.ucla.edu
Subject: Re: master afc0bfd380: Speed up loaddefs-generate on slow disks
Date: Fri, 03 Jun 2022 08:21:32 -0400	[thread overview]
Message-ID: <jwvpmjqym8f.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <838rqee1k4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Jun 2022 08:52:27 +0300")

>> This suggests that the kind of change I suggested would make it even
>> a bit faster, tho it should reduce the run time by less than 50%
>> under Windows (because the time to do the `stat`s is apparently already
>> >50% of the total).
>
> I don't know how you deduce the 50% figure.

The old code performed 2*N `stat`s.
The new current code performs N times `time-less-p` and
`file-attributes`, which is N `stat`s plus N times some overhead.
The proposed new functionality would reduce this to more or less just
N `stat`s so it would save us the "some overhead".

Because the old code is slower than the current code, we know that

    2*stat > stat + overhead

thus `stat > overhead`.  So `overhead` is less than 50% of `stat + overhead`.


        Stefan




  reply	other threads:[~2022-06-03 12:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165416120601.23485.9799765950267646757@vcs2.savannah.gnu.org>
     [not found] ` <20220602091326.514E9C009A8@vcs2.savannah.gnu.org>
2022-06-02 15:10   ` master afc0bfd380: Speed up loaddefs-generate on slow disks Stefan Monnier
2022-06-02 15:20     ` Lars Ingebrigtsen
2022-06-02 16:16       ` Eli Zaretskii
2022-06-03  1:18         ` Stefan Monnier
2022-06-03  5:52           ` Eli Zaretskii
2022-06-03 12:21             ` Stefan Monnier [this message]
2022-06-03 13:05               ` Eli Zaretskii
2022-06-03 13:09                 ` Stefan Monnier
2022-06-03 13:37                   ` Eli Zaretskii
2022-06-04 12:30       ` Lars Ingebrigtsen
2022-06-05 10:06         ` Mattias Engdegård
2022-06-05 14:08           ` Lars Ingebrigtsen
2022-06-06 11:26           ` Lars Ingebrigtsen
2022-06-06 12:01             ` Alan Mackenzie
2022-06-06 12:05               ` Lars Ingebrigtsen
2022-06-06 12:08             ` Lars Ingebrigtsen
2022-06-06 12:16               ` Mattias Engdegård
2022-06-06 12:32                 ` Lars Ingebrigtsen
2022-06-08 11:01                 ` Lars Ingebrigtsen
2022-06-06 12:18               ` Andreas Schwab
2022-06-06 12:28                 ` Lars Ingebrigtsen
2022-06-04 13:01       ` Lars Ingebrigtsen
2022-06-02 16:16     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpmjqym8f.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).