From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: noverlay branch Date: Sun, 09 Oct 2022 11:34:01 -0400 Message-ID: References: <87sfjzefvv.fsf@rfc20.org> <875ygt6gbj.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1254"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Matt Armstrong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 09 17:34:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohYKI-00005A-QY for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 17:34:51 +0200 Original-Received: from localhost ([::1]:54642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohYKH-0003dT-Hg for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 11:34:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohYJc-0002jZ-0v for emacs-devel@gnu.org; Sun, 09 Oct 2022 11:34:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohYJZ-0002Uo-MZ for emacs-devel@gnu.org; Sun, 09 Oct 2022 11:34:06 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AF9F41001D0; Sun, 9 Oct 2022 11:34:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5B68C1000DC; Sun, 9 Oct 2022 11:34:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665329642; bh=eMvL5ra3XacezzmjdJqJuCpvyP5K1HfrV+ClY2oRVWU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=B3IYqd1emivR5jBy7H7cBXYYpEkAE4r1qRqCpv7Q9fyEwasDWRVRx8vY4N0Q20Ma/ EuIz3VQh3Y59l8rA9hOwqyQaMgbCo8IDkdjSsPQr4mpxMUUT2divl8d+IcDhEp+3zv lRKrIiGOTFDfY/mBGQDNRVbN0YQ7A51OzvgNNPj00rGi3270z5pac/+ZQg3+yUlkKk ZrM6ypIfvLT3sN/5X4jEhN+nWvaixJdzGR3F1wQRIrFo4Pyap38MRnl8/d8VN4EXw2 K/6vjwHLCid79cVzQiVZUAlu3a9wwftNeCCSfKG/YNQeieuGWOf/PWK/LVVa6Ay0eD /Ilx8WwndLdJg== Original-Received: from milanesa (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0B499120E71; Sun, 9 Oct 2022 11:34:02 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 09 Oct 2022 00:12:49 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297281 Archived-At: >> node->otick = otick; > > Indeed, I saw later in the remove code that we do propagate offsets > without caring if they're up-to-date, and I think the logic behind that > is sound. And indeed we can drop the test because the only property we > only ever care about for an `otick` is whether it's equal to > `tree->otick`, so if node->parent->otick != otick then performing the > assignment is equivalent to not performing it. The above isn't quite right: I was thinking of `node->otick = parent->otick`. Stefan