From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Tue, 18 Oct 2022 17:40:18 -0400 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36643"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 18 23:42:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okuMJ-0009IJ-TZ for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Oct 2022 23:42:48 +0200 Original-Received: from localhost ([::1]:42406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okuMI-0007Ms-GZ for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Oct 2022 17:42:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okuK0-0006aX-E6 for emacs-devel@gnu.org; Tue, 18 Oct 2022 17:40:24 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okuJy-0000tk-Df for emacs-devel@gnu.org; Tue, 18 Oct 2022 17:40:24 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 029A280814; Tue, 18 Oct 2022 17:40:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 842D2803F2; Tue, 18 Oct 2022 17:40:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666129219; bh=l1VdTjGUEQFoeYmzMTsOF25QscgbNxucvJSk1rYP2kY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b5OdyovapyjovElHP4t7tmQJLinDqIMLntNI8fQAlBnoZtO32bAJnuF3dME3Nxx/O GBHMvkg7g92LR0Y/bCfee/hsnJWI34P43DqAlEYtQ6g0ndV7aoPpPPcpjNYXzA6NCU ssEPzU1Qqm5+iz3MRvzKtVxajUoTN2yVwfTKHLXidMINTx0xplKqEvKgTJUNlCamm2 LwGlL6X8PJ8lLPXmZNUJjWjoviahs/ddJS64+HA3wLAzCOP4kaDpBnefbghZXUMPXU 7fIzyakRN1usFj/OhCwjMOjeb0EC8uDJ8xxZm4fgmo39iABQF79LL611YdxvIkCKuj nmyUqyDxI/0tQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6EF8A120F16; Tue, 18 Oct 2022 17:40:19 -0400 (EDT) In-Reply-To: <87fsfkhnhm.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 18 Oct 2022 20:43:01 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298084 Archived-At: > I have pushed a first draft and it appears to work. It doesn't yet > handle all attribute (such as :doc), but that should be doable when I > find the time. Side note: installing packages from Git (like what you're implementing in the `package+vc` branch) is already one of the functionalities supported by `elpa-admin.el` so it would be good to try and share/reuse that code as much as possible. Actually part of `elpa-admin.el` might also be helpful for the ELPA-bundling feature. So we should move more of `elpa-admin.el` into Emacs's own code. > I wanted to add support for elpa-admin.el, Not sure what you mean. > and it will boil down to > something like this: > > (with-temp-buffer > (let ((filename (expand-file-name "elpa-packages" dir)) > (standard-output (current-buffer))) > ;; Remove and compress the contents of the "elpa-pacakges" > (prin1 (elpaa--get-specs)) > (write-region nil nil filename))) > > but I am uncertain where to add it, so that it only runs when necessary. > Do you have any ideas? Are you talking about the code which will run on `elpa.gnu.org` that is supposed to push some kind of copy of `elpa-packages` to the web site so clients can download it? We just need to export this as a function which we can then run from a cron job (tho you could also just call it from `elpaa-batch-make-all-packages`, so it's run as part of the main cron job). But note that we can't just write out (elpaa--get-specs): we also need to remove the `:core` packages and replace the nil `:url`s with URLs pointing to `elpa.git` or `nongnu.git` (with corresponding `:branch`). Stefan