unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 8bf4cdcf79: Avoid recursive process filters in lisp/jsonrpc.el (bug#60088)
Date: Fri, 16 Dec 2022 09:56:49 -0500	[thread overview]
Message-ID: <jwvpmcj2ygn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALDnm50ko733h8GDC2BCy0aKwGQRDKMjdXf7CpNPgmiFpJJHXw@mail.gmail.com> ("João Távora"'s message of "Fri, 16 Dec 2022 14:46:42 +0000")

> I thought about that too, but I don't know what other implications
> it might have. If it's somehow feasible, isn't it easier to just change
> process-send-input to _not_ accept output?  That's the
> only output-accepting primitive that makes sense to call from
> within a process filter (and that's what happened here).  I can't
> see how sit-for is useful from within a process-filter and neither
> accept-process-output.  Almost certainly a bug, right? So why
> can't we make it so that they just error when called under those
> circumstances?

To me, the only thing that *is* sure is that recursive invocations of
process filters are usually not expected (and because of
non-determinism they're usually not guaranteed either), so I'd focus
on this.

Trying to figure out when `process-send-input` should or shouldn't
accept process output (and from which processes) seems a lot more murky.

And I know `accept-process-output` can be (and is) used in
process filters.  I'd be surprised if the same didn't happen for
`sit-for`.


        Stefan




  reply	other threads:[~2022-12-16 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167118072395.30479.8819833637573037468@vcs2.savannah.gnu.org>
     [not found] ` <20221216085204.43B07C04961@vcs2.savannah.gnu.org>
2022-12-16 14:36   ` emacs-29 8bf4cdcf79: Avoid recursive process filters in lisp/jsonrpc.el (bug#60088) Stefan Monnier
2022-12-16 14:46     ` João Távora
2022-12-16 14:56       ` Stefan Monnier [this message]
2022-12-17  5:37     ` F. Jason Park
2022-12-17 15:37       ` Stefan Monnier
2022-12-17 21:39         ` João Távora
2022-12-18  1:57           ` Stefan Monnier
2022-12-18  4:08             ` João Távora
2022-12-18 14:32               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpmcj2ygn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).