From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: master 2de25accaf 4/4: Warn about `condition-case' with quoted condition names
Date: Thu, 29 Dec 2022 11:14:50 -0500 [thread overview]
Message-ID: <jwvpmc2ur1z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AFC018AD-7A3A-40A4-9597-2F589EB717BB@acm.org> ("Mattias Engdegård"'s message of "Thu, 29 Dec 2022 16:50:37 +0100")
Mattias Engdegård [2022-12-29 16:50:37] wrote:
> 29 dec. 2022 kl. 16.33 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>>> But do we know all errors statically at compile-time?
>>
>> Error identifiers should have an `error-conditions` property.
>
> You left the `error-conditions` property check commented out in
> `byte-compile-condition-case` so maybe it wasn't quite that straightforward?
I can't remember what came up, but my guess is that it's a question
of making the byte-compiler recognize `define-error` and things like
that (i.e. try and reduce the number of false positives where the error
is unknown at compile time but will be known at run-time).
Stefan
prev parent reply other threads:[~2022-12-29 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167231424264.29966.177874348975736593@vcs2.savannah.gnu.org>
[not found] ` <20221229114403.7EA13C05F48@vcs2.savannah.gnu.org>
2022-12-29 14:45 ` master 2de25accaf 4/4: Warn about `condition-case' with quoted condition names Stefan Monnier
2022-12-29 15:28 ` Mattias Engdegård
2022-12-29 15:33 ` Stefan Monnier
2022-12-29 15:50 ` Mattias Engdegård
2022-12-29 16:14 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpmc2ur1z.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).