From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction Date: Mon, 14 Aug 2023 10:39:26 -0400 Message-ID: References: <169195451549.1474.16374421496442723026@vcs2.savannah.gnu.org> <20230813192155.C53CEC295F9@vcs2.savannah.gnu.org> <87ttt22j2a.fsf@gmx.de> <18DBF0B1-8534-48C2-B5FE-4B324A93AB2A@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus , emacs-devel@gnu.org To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 14 16:40:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVYkL-0003oY-GF for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Aug 2023 16:40:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVYjG-0001lQ-HA; Mon, 14 Aug 2023 10:39:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVYjE-0001je-AX for emacs-devel@gnu.org; Mon, 14 Aug 2023 10:39:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVYjC-0000tl-OX for emacs-devel@gnu.org; Mon, 14 Aug 2023 10:39:32 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 128F3442748; Mon, 14 Aug 2023 10:39:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1692023967; bh=Q3ifihvst9XBDc88HJeb8PlgX1FnEI6XTrXOFqNBKfU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=L+oFZsPdF55SHzKJnRwRPpEaGtR30sJ2qcOUvPOaOFap9g52aXeefHByOPcuX4mvP WppI3ipWcd//z3nYgUjiFFgFKNOhOwXmhGsmmGV2OyWHz0F+6hKWheTlNPYpxBn+CW p64fWzY/PYj4gPmoCNJko8kT2r9bhww9M9BLsH7ABD4vr3uT8g8wj9fk1HqW7g/BnL u0S8y0ieLfABRQvLTfy6skibyBADt2Fj8CIRa5zxMv8LrcMILqdHGpVb7AXI/LsZyW qELp+BJ+guzULDA3Xctk9z7247tPu9mKvnkdb0r97HGSbXo2Z+FVx/nqlQTKlZdDFf k1dElkBV8EIGg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 79299442749; Mon, 14 Aug 2023 10:39:27 -0400 (EDT) Original-Received: from pastel (unknown [45.72.228.154]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 534DB12022A; Mon, 14 Aug 2023 10:39:27 -0400 (EDT) In-Reply-To: <18DBF0B1-8534-48C2-B5FE-4B324A93AB2A@gmail.com> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Mon, 14 Aug 2023 16:25:13 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308737 Archived-At: >> FWIW, I added it because I'm seeing tests (e.g. `file-tests.el`) hang in >> `read-event` (apparently because a (cl-letf ((symbol-function ..)) ..) >> rebinding is not taking effect :-( ) and I figured that batch tests >> should indeed never need interaction. > > I agree, but some tests persist. For example, abbrev-tests uses > ert-simulate-keys to 'interact' with Emacs. > Other test do morally equivalent things, and it is indubitably useful to be > able to test interactive features non-interactively in some way. Oh, I think I see: `inhibit-interaction` is probably tested too early, e.g. upon entry to `read-event` (which can return without user interaction if there's enough `unread-command-events` and friends) instead of upon entry to the actual code that waits for user input, so it doesn't quite do what I thought it would. Stefan