From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Excessive use of `eassert` Date: Sun, 21 Jan 2024 10:54:24 -0500 Message-ID: References: <83jzo5x0q8.fsf@gnu.org> <83sf2tv029.fsf@gnu.org> <811d5f03-fad4-47e1-b3fd-2f45229a5ee1@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34304"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 21 17:06:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRaLV-0008ff-0j for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jan 2024 17:06:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRaLF-000729-U6; Sun, 21 Jan 2024 11:06:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRaLD-00071h-Hj for emacs-devel@gnu.org; Sun, 21 Jan 2024 11:06:35 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRaLB-00078H-KX; Sun, 21 Jan 2024 11:06:35 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CAAF7100068; Sun, 21 Jan 2024 10:54:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1705852465; bh=i+1zTRJfd7zFgRDp0rAifAxZtFQg1VCrGLbhOZo6B9I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kkZ0jpTG8PgT2tamSMkOrEt8Xgx5ECEGNyFOKg4K3QTf0Disdv1sIZtPSQUQIk+ys BZXIliKdbYHmFhV4nVKjJHlBYAtOH7Wu4d0mytYSIoVBdyEWCxE/kP6M/bl5IxQlFC ePMaE2nAebfjhFUCRiVLygQM9WajMiSeqjGxDQ6G1AEsLiaD/j4MGk7nATBoxxL8xZ jRHI/uVLvJ7mZYCD97A+tQMxN34GEmjvODtht4eIeeueqRLJo+rXpxhfaSpUuI9yCV 4e8QwzZ1WaDQhn/usJxrsdK+ear3UXZmu4i9ayNDgnxk8zyzByPw0p0QxO5a72luxr RdENEblaeOO0g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8FA8E10004C; Sun, 21 Jan 2024 10:54:25 -0500 (EST) Original-Received: from alfajor (104-222-114-253.cpe.teksavvy.com [104.222.114.253]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 62DB3120283; Sun, 21 Jan 2024 10:54:25 -0500 (EST) In-Reply-To: <811d5f03-fad4-47e1-b3fd-2f45229a5ee1@cs.ucla.edu> (Paul Eggert's message of "Sat, 20 Jan 2024 17:41:57 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315183 Archived-At: > I looked into this a bit and installed the attached patches which should > speed things slightly even with a default build. Nice. > The main goal was to speed up debugging builds, though. I still get: (gdb) x/12i init_window 0xbbabc : push %ebx 0xbbabd : sub $0x18,%esp 0xbbac0 : call 0x235b0 <__x86.get_pc_thunk.bx> 0xbbac5 : add $0x34652f,%ebx 0xbbacb : lea 0xc(%esp),%eax 0xbbacf : lea 0x383d4c(%ebx),%edx 0xbbad5 : call 0xa2d57 0xbbada : mov 0xc(%esp),%eax 0xbbade : mov %eax,0x334230(%ebx) 0xbbae4 : add $0x18,%esp 0xbbae7 : pop %ebx 0xbbae8 : ret (gdb) whereas with my patch this goes down to: (gdb) x/4i init_window 0xb1715 : call 0x2ff9e <__x86.get_pc_thunk.ax> 0xb171a : add $0x31c8da,%eax 0xb171f : movl $0x0,0xe9d0(%eax) 0xb1729 : ret (gdb) =F0=9F=99=81 Stefan