From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/scala-mode df60066e31 4/5: Require version 25.1 Date: Fri, 27 Dec 2024 10:45:52 -0500 Message-ID: References: <173529003822.999392.7161642544221156448@vcs3.savannah.gnu.org> <20241227090039.5B112CED5C8@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29421"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Heikki Vesalainen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 27 16:47:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRCYL-0007Tp-7t for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Dec 2024 16:47:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRCXh-0001uE-EN; Fri, 27 Dec 2024 10:46:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRCXT-0001ko-9H for emacs-devel@gnu.org; Fri, 27 Dec 2024 10:46:23 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRCXM-0004SS-NZ for emacs-devel@gnu.org; Fri, 27 Dec 2024 10:46:09 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A2C9F440A47; Fri, 27 Dec 2024 10:46:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1735314360; bh=N9lRlLvC0mTyi0loI/GEJKprQdZ4+wqyTFsr2HIz76g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=B0AW30AQWflYDZiQ7q36ggVVbJLdVT1XWks3W/diO6td9KgykmR7bcx56i8itZTcu G0cF2ZxVtiATH1f3DiVe64DOEcTvwd24PxdwCtW16rr6ssoUhX5TTRxozrb8NKLCJC T2nsb5lYyQaos21K6+m9IF7ehWfRGJywoAuoedajYxwFQdWyvKcTT0QPk9h2yRgwBD UIUDHh48xCcDYuqba0fAEGppBuJmayHkmBzCaOmAnMqNc6Rd3UxM8UPxndGfs6W8zQ FqOeD7hylpkhXRNSwxEKyKdu/C9tPFj5IqAPLX2bk81TjfpgrW9FpLy22b97ZbBreE xsp/5uY0/1llg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7F6444407DD; Fri, 27 Dec 2024 10:46:00 -0500 (EST) Original-Received: from asado (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 51B9012033F; Fri, 27 Dec 2024 10:46:00 -0500 (EST) In-Reply-To: <20241227090039.5B112CED5C8@vcs3.savannah.gnu.org> (ELPA Syncer's message of "Fri, 27 Dec 2024 04:00:39 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327210 Archived-At: > -;; Tested only for emacs 24 > -(unless (<= 24 emacs-major-version) > +;; Tested only for emacs 25 > +(unless (<= 25 emacs-major-version) > (error > - (format "The Scala mode has been tested only on Emacs version 24.2 (and not your Emacs version %s.%s)" > + (format "The Scala mode has been tested only on Emacs version 25.1 (and not your Emacs version %s.%s)" > emacs-major-version emacs-minor-version))) I think the test should not be for "it is known to work with your Emacs" but "is it known *not* to work with your Emacs". If you know you use a feature of Emacs-25 without which your code won't work, then the test is right but the message is wrong. Else, you might want to relax your test (and change the message), or replace the `error` with a `message`. Stefan