From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Heikki Vesalainen <heikki.vesalainen@trademarknow.com>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/scala-mode df60066e31 4/5: Require version 25.1
Date: Fri, 27 Dec 2024 10:45:52 -0500 [thread overview]
Message-ID: <jwvplld8798.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20241227090039.5B112CED5C8@vcs3.savannah.gnu.org> (ELPA Syncer's message of "Fri, 27 Dec 2024 04:00:39 -0500 (EST)")
> -;; Tested only for emacs 24
> -(unless (<= 24 emacs-major-version)
> +;; Tested only for emacs 25
> +(unless (<= 25 emacs-major-version)
> (error
> - (format "The Scala mode has been tested only on Emacs version 24.2 (and not your Emacs version %s.%s)"
> + (format "The Scala mode has been tested only on Emacs version 25.1 (and not your Emacs version %s.%s)"
> emacs-major-version emacs-minor-version)))
I think the test should not be for "it is known to work with your Emacs"
but "is it known *not* to work with your Emacs".
If you know you use a feature of Emacs-25 without which your code won't
work, then the test is right but the message is wrong.
Else, you might want to relax your test (and change the message), or
replace the `error` with a `message`.
Stefan
parent reply other threads:[~2024-12-27 15:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241227090039.5B112CED5C8@vcs3.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvplld8798.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=heikki.vesalainen@trademarknow.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).