unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Quit within sit-for
Date: Mon, 09 Jun 2008 09:54:53 -0400	[thread overview]
Message-ID: <jwvod6azpil.fsf-monnier+emacs@gnu.org> (raw)

In your recent change to minibuffer.el you added:

        ;; A quit during sit-for should be (re-)read as
        ;; abort-recursive-edit
        (inhibit-quit t))

Other than the lack of "." at the end of the sentence, I'm worried that
if this fixes a bug, the bug is a lot more widespread.  But I must say
I don't understand the comment.

The comment seems to say that C-g within the sit-for be "(re-)read"
differently than if it had been typed at some other time.  Is that
really what your change is about?  If so, that sounds wrong (the
sit-for is only a display artifact and should ideally in no way
influence Emacs's behavior).

Or is it that without your change Emacs does behave differently within
the sit-for than outside of it and your change tries to bring the two
behaviors a bit closer to each other?


        Stefan


PS: *Please* reply with more than 1 line.




             reply	other threads:[~2008-06-09 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 13:54 Stefan Monnier [this message]
2008-06-09 14:19 ` Quit within sit-for Andreas Schwab
2008-06-10  1:21   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvod6azpil.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).