From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org
Subject: Re: `mouse-save-then-kill' changes
Date: Sun, 07 Nov 2010 22:38:54 -0500 [thread overview]
Message-ID: <jwvoca0tro8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <A986DCC3B20542DC8652F207412C8B34@us.oracle.com> (Drew Adams's message of "Sun, 7 Nov 2010 12:36:42 -0800")
>> > Now (Emacs 24) I have to (a) duplicate all of the code of
>> > `mouse-save-then-kill', (b) replace the 3 lines that delete or kill
>> > the region by a call to `foobar', and (c) change references to
>> > `mouse-save-then-kill' within the new command to the new command
>> > name - e.g. places where the code checks `(eq last-command
>> > 'mouse-save-then-kill)'.
>> Maybe you can use buffer-substring-filters instead?
> Thanks for suggesting something. But I don't really see how that var
> might fit in here. Can you elaborate?
I obviously can't, since I don't know what you're actually doing.
This said, rather than ask us to write the code differently so that you
can override an internal function (which is likely to get
renamed/inlined/changed at some point in the future), I recommend you
ask for a hook instead.
Stefan
next prev parent reply other threads:[~2010-11-08 3:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 17:49 `mouse-save-then-kill' changes Drew Adams
2010-11-07 19:01 ` Stefan Monnier
2010-11-07 20:36 ` Drew Adams
2010-11-08 3:38 ` Stefan Monnier [this message]
2010-11-08 4:42 ` Drew Adams
2010-11-08 9:11 ` tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoca0tro8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).