From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Marco Pessotto <melmothx@gmail.com>
Cc: rcyeske@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] rcirc: support TLS/SSL and arbitrary connection method
Date: Mon, 30 May 2011 22:24:53 -0300 [thread overview]
Message-ID: <jwvoc2jvfik.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fwnvvp3d.fsf@universe.krase.net> (Marco Pessotto's message of "Mon, 30 May 2011 23:46:30 +0200")
> I'm writing you to submit a patch for rcirc.el to give it support for
> SSL connections.
Thank you. But I'm afraid you're just a few weeks late:
revno: 104199
committer: Stefan Monnier <monnier@iro.umontreal.ca>
branch nick: trunk
timestamp: Wed 2011-05-11 23:25:58 -0300
message:
* lisp/net/rcirc.el: Add support for SSL/TLS connections.
(rcirc-server-alist): New field `encryption'.
(rcirc): Check `encryption' settings.
(rcirc-connect): New arg `encryption'. Use open-network-stream.
Merge make-local-variable into `set'.
(rcirc--connection-open-p): New function.
(rcirc-send-string, rcirc-clean-up-buffer): Use it to handle case where
the process is not a network process (e.g. running gnutls-cli).
(set-rcirc-decode-coding-system, set-rcirc-encode-coding-system):
Make rcirc-(en|de)code-coding-system local here.
(rcirc-mode): Merge make-local-variable into `set'.
(rcirc-parent-buffer): Make permanent buffer-local.
(rcirc-multiline-minor-mode): Don't do it here.
(rcirc-switch-to-server-buffer): Don't switch to a random buffer if
there's no server buffer.
> The last 2 chunks of the patch are meant to strip the IRC colors.
> Not really part of the "connection" patch, but IMHO useful.
Could you describe a bit more what this is about (I'm not a regular IRC
user)? I can't remember seeing those C-c escape sequences, when do they
appear, what are they expected to do? Should we really strip them, or
would it be even better to turn them into faces?
> In case you're interested, I signed the Emacs papers some years ago.
If you could send a new patch based on the latest code to provide the
remaining features, I'd be happy to install it.
Stefan
next prev parent reply other threads:[~2011-05-31 1:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 21:46 [PATCH] rcirc: support TLS/SSL and arbitrary connection method Marco Pessotto
2011-05-31 1:24 ` Stefan Monnier [this message]
2011-05-31 12:16 ` Julien Danjou
2011-05-31 12:58 ` Deniz Dogan
2011-05-31 14:21 ` Marco Pessotto
2011-05-31 14:57 ` Stefan Monnier
2011-05-31 15:35 ` Marco Pessotto
2011-05-31 8:07 ` Julien Danjou
2011-05-31 8:52 ` Marco Pessotto
2011-05-31 9:55 ` Ted Zlatanov
2011-05-31 11:16 ` Marco Pessotto
2011-06-07 22:27 ` Philipp Haselwarter
2011-06-08 3:32 ` Ted Zlatanov
2011-06-08 8:52 ` Julien Danjou
2011-06-08 14:22 ` auth-source for ERC (was: [PATCH] rcirc: support TLS/SSL and arbitrary connection method) Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoc2jvfik.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=melmothx@gmail.com \
--cc=rcyeske@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).