From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Proposal: 'struct window' cleanup Date: Wed, 23 May 2012 10:23:14 -0400 Message-ID: References: <4FBA5060.7070702@yandex.ru> <4FBB3B62.4070504@yandex.ru> <4FBC6C3E.6010909@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337783018 4995 80.91.229.3 (23 May 2012 14:23:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 May 2012 14:23:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 23 16:23:37 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SXCTN-0004pa-5o for ged-emacs-devel@m.gmane.org; Wed, 23 May 2012 16:23:33 +0200 Original-Received: from localhost ([::1]:39785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCTM-0002Te-N9 for ged-emacs-devel@m.gmane.org; Wed, 23 May 2012 10:23:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCTG-0002SQ-QH for emacs-devel@gnu.org; Wed, 23 May 2012 10:23:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXCT6-0007RY-Jm for emacs-devel@gnu.org; Wed, 23 May 2012 10:23:26 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:55391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCT6-0007RB-FU for emacs-devel@gnu.org; Wed, 23 May 2012 10:23:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09MCpYd/2dsb2JhbABEtBGBCIIWAQVWIxALDiYSFBgNJBOIAAMLugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="181972702" Original-Received: from 76-10-150-29.dsl.teksavvy.com (HELO pastel.home) ([76.10.150.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 May 2012 10:23:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id AAC0958C01; Wed, 23 May 2012 10:23:14 -0400 (EDT) In-Reply-To: <4FBC6C3E.6010909@yandex.ru> (Dmitry Antipov's message of "Wed, 23 May 2012 08:49:02 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.143.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150617 Archived-At: > === modified file 'src/ChangeLog' > --- src/ChangeLog 2012-05-22 18:31:19 +0000 > +++ src/ChangeLog 2012-05-23 04:38:27 +0000 > @@ -1,3 +1,38 @@ > +2012-05-23 Dmitry Antipov > + > + For a 'struct window', replace some Lisp_Object fields to > + bitfields where appropriate, remove unused fields. > + * window.h (struct window): remove unused 'last_mark_x' and > + 'last_mark_y' fields. > + * window.h (struct window): rename 'mini_p' field to 'mini', > + change it's type from Lisp_Object to bitfield. > + * window.h (struct window): change type of 'force_start', > + 'optional_new_start', 'last_had_star', 'update_mode_line' > + and 'start_at_line_beg' fields from Lisp_Object to bitfield. Please capitalize your sentences. And you can merge those three: For a 'struct window', replace some Lisp_Object fields to bitfields where appropriate, remove unused fields. * window.h (struct window): Remove unused 'last_mark_x' and 'last_mark_y' fields. Rename 'mini_p' field to 'mini', change it's type from Lisp_Object to bitfield. Change type of 'force_start', 'optional_new_start', 'last_had_star', 'update_mode_line' and 'start_at_line_beg' fields from Lisp_Object to bitfield. > + * fileio.c (Finsert_file_contents): adjusted for a new > + type of 'start_at_line_beg'. > + * frame.c (make_frame, make_minibuffer_frame): adjusted for > + a new type of 'mini'. > + * keyboard.c (command_loop_1): adjusted for a new type > + of 'force_start'. > + * window.c (Fset_window_start, window_loop) > + (Fdelete_other_windows_internal, set_window_buffer) > + (Fforce_window_update, make_window, window_scroll_pixel_based) > + (window_scroll_line_based, Frecenter, Fmove_to_window_line) > + (Fset_window_configuration, save_window_save): adjusted for > + a type changes in 'struct window'. > + * xdisp.c (update_menu_bar, update_tool_bar): adjusted for > + a new type of 'last_had_star' and 'update_mode_line'. > + * xdisp.c (redisplay_internal): adjusted for a new type > + of 'update_mode_line', 'force_start' and 'optional_new_start'. > + * xdisp.c (mark_window_display_accurate_1): adjusted for > + a new type of 'last_had_star' and 'update_mode_line'. > + * xdisp.c (redisplay_window): adjusted for > + a type changes in 'struct window'. > + * xdisp.c (try_window): adjusted for a new type of 'update_mode_line'. > + * xfns.c (x_set_menu_bar_lines): adjusted for a new type > + of 'update_mode_line'. All these can be summarized by "Adjust users accordingly" in the "* window.h (struct window):" entry. The rest of the patch looks ready for installation. IOW, please install it, and thank you, Stefan